Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Jakarta Faces 4 #82

Merged
merged 14 commits into from
Nov 11, 2022
Merged

Update to Jakarta Faces 4 #82

merged 14 commits into from
Nov 11, 2022

Conversation

avpinchuk
Copy link
Contributor

Fix incompatibility with Jakarta Faces 4.

Fixes eclipse-ee4j/glassfish#23782

@avpinchuk
Update Jakarta API version
311e989 
Signed-off-by: avpinchuk <alexander.v.pinchuk@gmail.com>
@avpinchuk
Update mojarra version to 4.0.0
080cd3f 
Signed-off-by: avpinchuk <alexander.v.pinchuk@gmail.com>
@avpinchuk
Update minimal required Java version to 11
63dc181 
Signed-off-by: avpinchuk <alexander.v.pinchuk@gmail.com>
@avpinchuk
Migrate Faces bean management to CDI
71c350d 
Signed-off-by: avpinchuk <alexander.v.pinchuk@gmail.com>
@avpinchuk
Update bundle manifest
90ef15b 
Signed-off-by: avpinchuk <alexander.v.pinchuk@gmail.com>
@avpinchuk
Migrate page session variable resolver to EL
7090e45 
Signed-off-by: avpinchuk <alexander.v.pinchuk@gmail.com>
@avpinchuk
Fix view state management
b1b571e 
Signed-off-by: avpinchuk <alexander.v.pinchuk@gmail.com>
@avpinchuk
Fix view creation
041723a 
Signed-off-by: avpinchuk <alexander.v.pinchuk@gmail.com>
@avpinchuk
Fix obsoleted API
b1a721f 
Signed-off-by: avpinchuk <alexander.v.pinchuk@gmail.com>
@avpinchuk
Implements absent methods in context mocker
a6cd348 
Signed-off-by: avpinchuk <alexander.v.pinchuk@gmail.com>
@avpinchuk
Update descriptors to version 4.0
04a42ea 
Signed-off-by: avpinchuk <alexander.v.pinchuk@gmail.com>
@avpinchuk
Exclude null viewId from mapped views
9667337 
Signed-off-by: avpinchuk <alexander.v.pinchuk@gmail.com>
@avpinchuk
Fix license header years
1e5e89c 
Signed-off-by: avpinchuk <alexander.v.pinchuk@gmail.com>
@avpinchuk
Yet another fix license headers
6afce6c 
Signed-off-by: avpinchuk <alexander.v.pinchuk@gmail.com>
@avpinchuk avpinchuk changed the title Update to Jakarts Faces 4 Update to Jakarta Faces 4 Nov 3, 2022
dmatej
dmatej approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@dmatej dmatej left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, great!
Code seams reasonable, but I did not try yet.

@avpinchuk
Copy link
Contributor Author

@dmatej, I need wip branch for GlassFish to pull my patch

@dmatej
Copy link
Contributor

dmatej commented Nov 4, 2022

@dmatej, I need wip branch for GlassFish to pull my patch

I have created branch admingui7 here https://github.com/eclipse-ee4j/glassfish/tree/admingui7

@avpinchuk avpinchuk mentioned this pull request Nov 4, 2022
Merged
@arjantijms arjantijms merged commit 22d585c into eclipse-ee4j:faces4 Nov 11, 2022
@pzygielo pzygielo added this to the 4.0.0 milestone Nov 29, 2022
This was referenced Apr 22, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmatej dmatej dmatej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@avpinchuk @dmatej @arjantijms @pzygielo