Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AdminGUI for GF7 #24151

Merged
merged 12 commits into from
Nov 4, 2022
Merged

Conversation

avpinchuk
Copy link
Contributor

Fixes an incompatibility administrator's console with GF7.

Related PR's
eclipse-ee4j/glassfish-jsftemplating#82
eclipse-ee4j/glassfish-woodstock#1421

Fixes #23782

Signed-off-by: Alexander Pinchuk alexander.v.pinchuk@gmail.com

Signed-off-by: avpinchuk <alexander.v.pinchuk@gmail.com>
Signed-off-by: avpinchuk <alexander.v.pinchuk@gmail.com>
Signed-off-by: avpinchuk <alexander.v.pinchuk@gmail.com>
Signed-off-by: avpinchuk <alexander.v.pinchuk@gmail.com>
Signed-off-by: avpinchuk <alexander.v.pinchuk@gmail.com>
Signed-off-by: avpinchuk <alexander.v.pinchuk@gmail.com>
Signed-off-by: avpinchuk <alexander.v.pinchuk@gmail.com>
Signed-off-by: avpinchuk <alexander.v.pinchuk@gmail.com>
Signed-off-by: avpinchuk <alexander.v.pinchuk@gmail.com>
Signed-off-by: avpinchuk <alexander.v.pinchuk@gmail.com>
Signed-off-by: avpinchuk <alexander.v.pinchuk@gmail.com>
Signed-off-by: avpinchuk <alexander.v.pinchuk@gmail.com>
@glassfish-bot
Copy link
Contributor

Can one of the admins verify this patch?

@avpinchuk
Copy link
Contributor Author

avpinchuk commented Nov 4, 2022

We need to repackage jackson-module-jakarta-xmlbind-annotations because they depends on jakarta.xml.bind version 3, but GF7 contains version 4 of this artifact. Snapshot versions of this module does not resolve the problem

@dmatej dmatej merged commit 2daba85 into eclipse-ee4j:admingui7 Nov 4, 2022
@dmatej
Copy link
Contributor

dmatej commented Nov 4, 2022

We need to repackage jackson-module-jakarta-xmlbind-annotations because they depends on jakarta.xml.bind version 3, but GF7 contains version 4 of this artifact. Snapshot versions of this module does not resolve the problem

By snapshot you mean 2.14+? We could create a PR, seems they push rc versions quite often to Maven Central ... another option is repackaging as you wrote.
https://mvnrepository.com/artifact/com.fasterxml.jackson.module/jackson-module-jakarta-xmlbind-annotations/2.14.0-rc3

@avpinchuk
Copy link
Contributor Author

avpinchuk commented Nov 4, 2022

By snapshot you mean 2.14+? We could create a PR, seems they push rc versions quite often to Maven Central ... another option is repackaging as you wrote. https://mvnrepository.com/artifact/com.fasterxml.jackson.module/jackson-module-jakarta-xmlbind-annotations/2.14.0-rc3

Yes, 2-x branch of Jackson still depends on jakarta xml bind api v3. Also, this Jackson module has redundant old javax.activation dependency, but they does not use neither javax.activation nor jakarta.activation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants