Set OptimizedAccessorFactory.noOptimization=true by default

[jimma]

No description provided.

[lukasj]

What problem on which JDK is this trying to resolve? In all cases I've seen on JDK 11+ so far was that the caller did not support multi-release jar files (ie Ant <=1.10.6); in such case using -Djdk.util.jar.enableMultiRelease=force is the way to go

[jimma]

@lukasj I see there is a huge performance decrease in jaxb 2.3.3 with jdk8 with this default value OptimizedAccessorFactory.noOptimization=false . From my local test, I don't see there is some performance improvement with this optimization and JDK11. So I think it's better set this value as true as it's backward compatible and faster on different JDK versions.

[lukasj]

Since JDK 9, this is off by default (noOptimization is true). Can you share a testcase showing the decrease on JDK8?

[jimma]

@lukasj Can you please point me the source code to set this off (noOptimazation is true) by default since JDK9 ?

[lukasj]

see the Injector which does nothing and is supposed to be used

[jimma]

Thanks @lukasj .

Can you share a testcase showing the decrease on JDK8?

I pushed the test case project for the performance issue with JDK8: https://github.com/jimma/jaxb233perfmance . The steps to reproduce this issue are listed on README. Please check.

[jimma]

@lukasj Did you get time to look at the producer ? The optimization change in jaxb 2.3.3. makes creates JAXBContext instance 10 times slower than jaxb 2.3.2.

[lukasj]

yup, you're right. Anyway, correct way to fix it is to just remove the code completely instead of setting variable to true - that can be done via system property even now

[jimma]

OK. @lukasj , I reverted this change with #1533. Please review.

[lukasj]

superseded by #1533