Revert "Revert optimization removal (#1352)" #1533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 263e92e.
lukasj
reviewed
Apr 13, 2021
lukasj
reviewed
Apr 13, 2021
There was a problem hiding this comment.
In general, this is a good start.
What needs to be done:
- the output of the build is supposed to be multi-release jar but the execution to compile versioned sources is being removed, which is wrong
- there are few other files to be removed in tests and in
src/main/java-mrfolder
|
@lukasj Thanks for the review. I've fixed these things. Please review this again. |
lukasj
reviewed
Apr 21, 2021
| * Copyright (c) 1997, 2020 Oracle and/or its affiliates. All rights reserved. | ||
| ======= | ||
| * Copyright (c) 1997, 2018 Oracle and/or its affiliates. All rights reserved. | ||
| >>>>>>> parent of 263e92e (Revert optimization removal (#1352)):jaxb-ri/runtime/impl/src/main/java/com/sun/xml/bind/v2/runtime/FilterTransducer.java |
lukasj
reviewed
Apr 21, 2021
|
I'll just fix/remove the rest myslef... |
|
Thanks @lukasj. Are you going to back port this change to 2.3.x too ? |
lukasj
pushed a commit
to lukasj/jaxb-ri
that referenced
this pull request
Apr 26, 2021
…j#1533) * Revert "Revert optimization removal (eclipse-ee4j#1352)" This reverts commit 263e92e. (cherry picked from commit a5cf4bd)
|
it's already there, see #1540 |
|
@lukasj Nice! Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 263e92e.