Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SseEventSource cannot see the JAXRS_DEFAULT_SSE_BUILDER in OSGI #4649

Closed
maho7791 opened this issue Dec 2, 2020 · 1 comment · Fixed by #4682
Closed

SseEventSource cannot see the JAXRS_DEFAULT_SSE_BUILDER in OSGI #4649

maho7791 opened this issue Dec 2, 2020 · 1 comment · Fixed by #4682
Labels
bug Something isn't working osgi
Milestone

Comments

@maho7791
Copy link

maho7791 commented Dec 2, 2020

Because the package org.glassfish.jersey.media.sse.internal is not exported in the jersey-media-sse bundle,e.g. the JaxRs client is not able to load the default SSE builder.

This is a constellation that will never work.
A possible solution could be to introduce a factory in the SSE that can be instanciated reflectivley and then create the builder instance in the javax.ws.rs.ext.sse.FactoryFinder#find call

There is an initial issues at the JaxRs-api repository that is related to this, because I believe SSE and API are involved in that problem:
jakartaee/rest#925

@jansupol
Copy link
Contributor

jansupol commented Dec 2, 2020

Basically, we have two possible options:

  • make the internal package available for OSGi
  • create a class in a noninternal package that extends the internal one and we load it via the service loading mechanism

I wonder if there is more OSGi catches like that throughout Jersey

@jansupol jansupol added the osgi label Dec 2, 2020
@jansupol jansupol added the bug Something isn't working label Jan 6, 2021
@senivam senivam linked a pull request Jan 14, 2021 that will close this issue
@jansupol jansupol added this to the 2.34 milestone Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working osgi
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants