Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inproper parsing of ORBTCPTimeouts #2

Closed
glassfishrobot opened this issue May 14, 2008 · 5 comments
Closed

Inproper parsing of ORBTCPTimeouts #2

glassfishrobot opened this issue May 14, 2008 · 5 comments

Comments

@glassfishrobot
Copy link

When setting TCP timeouts per this article:
http://blogs.sun.com/ejcorba/entry/more_on_tcp_timeouts_in

By setting the setting the System property:
-Dcom.sun.corba.ee.transport.ORBTCPTimeouts=500:30000:20

Glassfish ORB throws an exception saying that the timeouts need to "3 positive
decimal integers separated by :"

I traced this exception down to line #61 in TcpTimeoutsImpl
(http://mercurial2.foundry.sun.com/corba/corba-gfv2-master/file/0fc818f2f9e5/src/share/classes/com/sun/corba/se/impl/transport/TcpTimeoutsImpl.java)

The conditional states:
if ((data.length <= 3) || (data.length > 4))

I think the '(data.length <= 3)' should be '(data.length < 3)' to allow for 3 or
4 arguments.

Environment

Operating System: All
Platform: All

@glassfishrobot
Copy link
Author

@glassfishrobot Commented
Reported by heartsjava

@glassfishrobot
Copy link
Author

@glassfishrobot Commented
kcavanaugh said:
I have already fixed this in the GlassFish v3 CORBA version.
We'll be integrating that ORB into GFv3 probably in the next
month or two.

@glassfishrobot
Copy link
Author

@glassfishrobot Commented
This issue was imported from java.net JIRA GLASSFISH_CORBA-2

@glassfishrobot
Copy link
Author

@pzygielo
Copy link
Contributor

pzygielo commented Sep 3, 2023

Seems to be fixed in 40b2f82

@pzygielo pzygielo closed this as completed Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants