Fix for #340 - JNDI lookup returns object or throws exception #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion - Both usages in Soteria require an object, null results in exceptions - BeanManager can have two possible JNDI names, we don't care which, we need an instance. - The lookup now allows to provide a list contexts which are processed in order. - IllegalStateException was replaced by NamingException. It's message simply reports used unsuccessful names. - BeanManager is used in functions etc, so the exception may be wrapped by IllegalStateException again. Null cannot be provided (old impl then resulted in NullpointerException). - DataSource can still result in the same exception if it is not available, but new impl simplified the code. Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: David Matějček david.matejcek@omnifish.ee