[646] Fixed possible client hang when connecting to server.

When using secure connection (wss) while in the conditions of a bad
network connection, the client connection thread can hang in
JdkClientContainer's connectSynchronously() method, because it never
receives neither completed() nor failed() callback.
Missing failed() call added for fix.

Bug: #646
Signed-off-by: Vladimir Golyakov <wolodia@narod.ru>

containers/jdk-client/src/main/java/org/glassfish/tyrus/container/jdk/client/ClientFilter.java

@@ -210,6 +210,9 @@ public void close(CloseReason reason) {
     @Override
     public void processConnectionClosed() {
         LOGGER.log(Level.FINE, "Connection has been closed by the server");
+        if (connectCompletionHandler != null) {
+            connectCompletionHandler.failed(new IOException("Connection closed by server"));
+        }
 
         if (wsConnection == null) {
             return;

containers/jdk-client/src/test/java/org/glassfish/tyrus/container/jdk/client/ConnectSynchronouslyHangTest.java

@@ -0,0 +1,93 @@
+/*
+ * Copyright (c) 2014, 2021 Oracle and/or its affiliates. All rights reserved.
+ *
+ * This program and the accompanying materials are made available under the
+ * terms of the Eclipse Public License v. 2.0, which is available at
+ * http://www.eclipse.org/legal/epl-2.0.
+ *
+ * This Source Code may also be made available under the following Secondary
+ * Licenses when the conditions for such availability set forth in the
+ * Eclipse Public License v. 2.0 are satisfied: GNU General Public License,
+ * version 2 with the GNU Classpath Exception, which is available at
+ * https://www.gnu.org/software/classpath/license.html.
+ *
+ * SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
+ */
+
+package org.glassfish.tyrus.container.jdk.client;
+
+import java.io.IOException;
+import java.net.ServerSocket;
+import java.net.Socket;
+import java.util.concurrent.TimeUnit;
+
+import javax.websocket.ClientEndpoint;
+
+import org.glassfish.tyrus.client.ClientManager;
+import org.glassfish.tyrus.test.tools.TestContainer;
+
+import org.junit.Test;
+import static org.junit.Assert.assertFalse;
+
+/**
+ * @author Vladimir Golyakov
+ */
+public class ConnectSynchronouslyHangTest extends TestContainer {
+
+    @Test
+    public void testConnectSynchronouslyHang() throws IOException, InterruptedException {
+        Thread clientThread = null;
+        ServerSocket server = startBadServer();
+        try {
+            clientThread = new Thread() {
+                @Override
+                public void run() {
+                    ClientManager client = ClientManager.createClient(JdkClientContainer.class.getName());
+                    try {
+                        client.connectToServer(AnnotatedClientEndpoint.class, getURI("/any-endpoint", "wss"));
+                    } catch (Exception e) {
+                        // ignore
+                    } finally {
+                        client.shutdown();
+                    }
+                }
+            };
+            clientThread.start();
+
+            // Wait for client to hang or not
+            clientThread.join(TimeUnit.SECONDS.toMillis(5));
+            assertFalse("Client hangs", clientThread.isAlive());
+        } finally {
+            if (clientThread != null) {
+                clientThread.interrupt();
+            }
+            server.close();
+        }
+    }
+
+    private ServerSocket startBadServer() throws IOException {
+        final ServerSocket serverSocket = new ServerSocket(getPort());
+        new Thread() {
+            @Override
+            public void run() {
+                // Server accepts client connection and disconnects for some reason
+                try {
+                    serverSocket.setSoTimeout((int) TimeUnit.SECONDS.toMillis(5));
+                    Socket clientSocket = serverSocket.accept();
+                    try {
+                        Thread.sleep(200);
+                    } finally {
+                        clientSocket.close();
+                    }
+                } catch (Exception e) {
+                    // ignore
+                }
+            }
+        }.start();
+        return serverSocket;
+    }
+
+    @ClientEndpoint
+    public static class AnnotatedClientEndpoint {
+    }
+}