Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep target platform dependencies up-to-date #34

Closed
merks opened this issue May 16, 2024 · 8 comments
Closed

Keep target platform dependencies up-to-date #34

merks opened this issue May 16, 2024 · 8 comments
Labels
enhancement New feature or request

Comments

@merks
Copy link
Contributor

merks commented May 16, 2024

Description

Orbit generates a report for EGit's target platform:

https://github.com/eclipse-orbit/orbit-simrel/blob/main/report/maven-osgi/egit/REPORT.md

You can literally copy and paste this updated version:

https://github.com/eclipse-orbit/orbit-simrel/blob/main/report/maven-osgi/egit/updated.target

to replace this version:

https://raw.githubusercontent.com/eclipse-egit/egit/master/org.eclipse.egit.target/egit-4.32.target

The reports are generally regenerated 5+ times per week.


These updates are currently available:

Minor Updates

Motivation

It's best to use the latest dependencies.

Alternatives considered

No response

Additional context

No response

@merks merks added the enhancement New feature or request label May 16, 2024
@merks
Copy link
Contributor Author

merks commented May 20, 2024

I've been looking closely at how EGit/JGit define the target platforms using TPD and am looking at updating Orbit's maven dependency analyzer to analyze/updates the *.tpd file instead of the generated *.target.

I get the impression that perhaps these "duplicates" were added by mistake:

dependency {
groupId = "commons-io"
artifactId = "commons-io"
version = "2.15.1"
}
dependency {
groupId = "commons-io"
artifactId = "commons-io"
version = "2.15.0"
}

Is that correct, i.e., are these duplicates pointless?

Also, after the Orbit generator updates the dependencies.tpd and I then regenerate a *.target with TPD, there are a lot of whitespace difference. I'm wondering how exactly the *.target was produced in the past such that it contains tab characters?

image

@merks
Copy link
Contributor Author

merks commented May 21, 2024

FYI, the report generator now generates an updated *.tpd:

https://github.com/eclipse-orbit/orbit-simrel/blob/main/report/maven-osgi/egit/updated.tpd

@msohn
Copy link
Member

msohn commented May 21, 2024

This change series has the updates for EGit target platform:
https://eclipse.gerrithub.io/c/eclipse-egit/egit/+/1194983

https://eclipse.gerrithub.io/c/eclipse-egit/egit/+/1194980 also removes the duplicate version for commons-io

@msohn
Copy link
Member

msohn commented May 21, 2024

The .target files are generated in Eclipse IDE using the "Target Platform Definition DSL and Generator" plugin's action "Create Target Definition File".

@msohn
Copy link
Member

msohn commented May 21, 2024

submitted the updates

@msohn msohn closed this as completed May 21, 2024
@Bananeweizen
Copy link
Contributor

Also, after the Orbit generator updates the dependencies.tpd and I then regenerate a *.target with TPD, there are a lot of whitespace difference. I'm wondering how exactly the *.target was produced in the past such that it contains tab characters?

The TPD generator generated tab characters until one year ago, when I fixed that in eclipse-cbi/targetplatform-dsl@26559a6. So the files have not been re-generated at all or with a more recent version of the TPD plugin since then. Not sure if someone needs to run Help>Perform Setup tasks maybe to force a local update.

@merks
Copy link
Contributor Author

merks commented May 27, 2024

@Bananeweizen

Yes, I had a feeling older tooling was involved. The current output with just spaces is nicer...

@msohn
Copy link
Member

msohn commented May 27, 2024

caught me, will update the TPD plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants