Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused distinction between Plug-ins and Fragments in products #378

Conversation

HannesWell
Copy link
Member

@HannesWell HannesWell commented Nov 5, 2023

Remove unused distinction between Plug-ins and Fragments in .product files.
There is no usage of a product's fragments in P2 or PDE.
I also checked Tycho (5 but I assume it's the same for Tycho 4) and it never calls IProductDescriptor.getFragments() and calls IProductDescriptor.getBundles(boolean includeFragments) with includeFragments=true.

So it looks like this distinction is unused and can be removed too.

Consequently PDE support for adding a fragment attribute for fragments listed in a product file can be removed too and I will create a PR dedicated to that.

This was originally part of #368, but since the second part there needs some more adoptions in PDE I will postpone that but would like to land this for the December release.

@laeubi
Copy link
Member

laeubi commented Nov 5, 2023

Consequently PDE support for adding a fragment attribute for fragments listed in a product file can be removed too and I will create a PR dedicated to that.

Never been aware of that one can switch it, I think its there for the same historic reasons it was added to features...

Copy link
Member

@laeubi laeubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its all internal API and adjustments seems minimal, maybe @merks has some concerns but from Tycho side we will simply adopt.

Copy link

github-actions bot commented Nov 5, 2023

Test Results

       9 files         9 suites   38m 21s ⏱️
2 180 tests 2 176 ✔️   4 💤 0
6 630 runs  6 619 ✔️ 11 💤 0

Results for commit ff6b8a8.

HannesWell added a commit to HannesWell/eclipse.pde that referenced this pull request Nov 5, 2023
The PDE Product Editor used to add a 'fragment' attribute to plugin
elements in *.product files, but the attribute is unused for a long
time.

Relates to eclipse-equinox/p2#378
@HannesWell
Copy link
Member Author

Consequently PDE support for adding a fragment attribute for fragments listed in a product file can be removed too and I will create a PR dedicated to that.

Never been aware of that one can switch it, I think its there for the same historic reasons it was added to features...

I assume the same about the history.
You cannot explicitly set it. The PDE Product editor (currently) just adds a fragment attribute if a plugin is a fragment:

   <plugins>
      <plugin id="org.eclipse.core.net.win32" fragment="true"/>
      <plugin id="org.eclipse.pde.core"/>
   </plugins>

Here is the PDE pendant: eclipse-pde/eclipse.pde#882

Its all internal API and adjustments seems minimal, maybe @merks has some concerns but from Tycho side we will simply adopt.

For Tycho I already started a commit locally to adapt to all the internal changes done in P2 in this release.
I'll create a PR with that once the release is further down the ramp.

Copy link
Contributor

@merks merks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fortunately I don't call the changed methods so it's not a problem.

@HannesWell HannesWell merged commit b8b4f9d into eclipse-equinox:master Nov 5, 2023
9 checks passed
@HannesWell HannesWell deleted the removeUnusedProductFragmentAttribute branch November 5, 2023 11:23
HannesWell added a commit to eclipse-pde/eclipse.pde that referenced this pull request Nov 5, 2023
The PDE Product Editor used to add a 'fragment' attribute to plugin
elements in *.product files, but the attribute is unused for a long
time.

Relates to eclipse-equinox/p2#378
Dinesh0723 pushed a commit to Dinesh0723/eclipse.pde that referenced this pull request Nov 7, 2023
The PDE Product Editor used to add a 'fragment' attribute to plugin
elements in *.product files, but the attribute is unused for a long
time.

Relates to eclipse-equinox/p2#378
@HannesWell HannesWell added the noteworthy Noteworthy feature label Nov 11, 2023
@HannesWell
Copy link
Member Author

Created N&N entry for this: eclipse-platform/www.eclipse.org-eclipse#84

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
noteworthy Noteworthy feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants