Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary 'fragment' attribute of plugin-elements in products #882

Merged

Conversation

HannesWell
Copy link
Member

The PDE Product Editor used to add a fragment attribute to plugin elements in *.product files, but the attribute is unused for a long time.

Relates to eclipse-equinox/p2#378

The PDE Product Editor used to add a 'fragment' attribute to plugin
elements in *.product files, but the attribute is unused for a long
time.

Relates to eclipse-equinox/p2#378
Copy link

github-actions bot commented Nov 5, 2023

Test Results

     270 files  +       6       270 suites  +6   59m 12s ⏱️ + 6m 51s
  3 327 tests  -        1    3 297 ✔️ ±       0  30 💤 ±  0  0  - 1 
10 278 runs  +2 721  10 188 ✔️ +2 698  90 💤 +24  0  - 1 

Results for commit 892c0c1. ± Comparison against base commit 3f94107.

This pull request removes 1 test.
AllPDETests org.eclipse.pde.ui.tests.launcher.AllLauncherTests org.eclipse.pde.ui.tests.launcher.FeatureBasedLaunchTest ‑ Unknown test

@HannesWell HannesWell merged commit 84b2e1e into eclipse-pde:master Nov 5, 2023
16 checks passed
@HannesWell HannesWell deleted the removeUnusedFragmentAttribute branch November 5, 2023 11:26
@HannesWell HannesWell added the noteworthy Noteworthy feature label Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
noteworthy Noteworthy feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant