Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add N&N about removal of unnecessary attributes in Features and Products #84

Merged
merged 1 commit into from
Nov 11, 2023

Conversation

Copy link
Contributor

@merks merks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name of the Feature-editor in the UI is Feature Manifest Editor and the name of the Product-editor in the UI is Product Configuration Editor. it's probably better to use the actual names as seen in the Open With menue.

@HannesWell
Copy link
Member Author

The name of the Feature-editor in the UI is Feature Manifest Editor and the name of the Product-editor in the UI is Product Configuration Editor. it's probably better to use the actual names as seen in the Open With menue.

Thanks Ed, I updated the name from Product-editor to Product Configuration Editor.
But I have to admit that Feature Manifest Editor has IMHO the potential to confuse people and I would like to keep that as it is.
Maybe it would be better to change the 'official' name to only Feature Editor?

Copy link
Contributor

@merks merks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's a terrible name for the feature editor and would be better changed. Even the product editor's name is kind of pointlessly unwieldy...

In any case, it looks better without they hyphenated names.

@HannesWell
Copy link
Member Author

Yes, it's a terrible name for the feature editor and would be better changed. Even the product editor's name is kind of pointlessly unwieldy...

Absolutely, that's something to change for the spring release. :)

Thanks again for your input.

@HannesWell HannesWell merged commit 18fb601 into eclipse-platform:master Nov 11, 2023
1 check passed
@HannesWell HannesWell deleted the attributes-cleanup branch November 11, 2023 15:22
elsazac pushed a commit to elsazac/www.eclipse.org-eclipse that referenced this pull request Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants