-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add common Disposable API #222
Conversation
+ Autoformat package.json files
Provide a reusable Disposable API similar to what Theia/VS Code uses Fixes eclipse-glsp/glsp#867
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API looks good to me in general, thank you very much Tobias! If we ever need more functionality (e.g., listeners) we can always add them later. I was only wondering on whether we should already use the API in this package, e.g., there are a few places where we have register
/deregister
methods (e.g., tools, listeners, etc.) where the register
call could return the corresponding deregister instead of void. Or will there be a separate task/PR for that?
I think we should do that in a separate PR. |
Co-authored-by: Martin Fleck <mfleck@eclipsesource.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Provide a reusable Disposable API similar to what Theia/VS Code uses
Part of eclipse-glsp/glsp#867
Also: Update dev packages and autoformat package.json files