Ensure that all services that return MaybePromises are properly awaited #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove Disposable and MaybePromise API and use protocol definitions instead. -Ensure that Action/Operation handlers use MaybePromise as return type when applicable - Ensure that the GLSPServer.process method forwards all unhandled errors to the client as notification
Otherwise we the server might crash in error cases due to unhandled promise rejections Contributed on behalf of STMicroelectronics
tortmayr
force-pushed
the
issue/fix-api
branch
from
6402a3b
to
5091082
Compare
martin-fleck-at
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we the server might crash in error cases due to unhandled promise rejections
Fixes eclipse-glsp/glsp#868
General cleanups/minor refactorings:
Contributed on behalf of STMicroelectronics
Requires eclipse-glsp/glsp-client#222