Improve external navigation support through dedicated action #153
Assignees
Projects
Comments
martin-fleck-at
added a commit
that referenced
this issue
Dec 1, 2020
- Add new NavigateToExternalTargetAction to protocol Part of /issues/153 Signed-off-by: Martin Fleck <mfleck@eclipsesource.com>
martin-fleck-at
added a commit
to eclipse-glsp/glsp-client
that referenced
this issue
Dec 1, 2020
- Introduce dedicated 'NavigateToExternalTarget' action - Replace external target service with action handler Part of eclipse-glsp/glsp/issues/153 Signed-off-by: Martin Fleck <mfleck@eclipsesource.com>
martin-fleck-at
added a commit
to eclipse-glsp/glsp-server
that referenced
this issue
Dec 1, 2020
- Introduce dedicated 'NavigateToExternalTarget' action - Fix issue with wrong field name in 'NavigateToTarget' action Part of eclipse-glsp/glsp/issues/153 Signed-off-by: Martin Fleck <mfleck@eclipsesource.com>
martin-fleck-at
added a commit
to eclipse-glsp/glsp-theia-integration
that referenced
this issue
Dec 1, 2020
- Replace TheiaNavigateToTargetHandler service with action handler - Refactor: Provide GLSP-Theia diagram configuration base class Part of eclipse-glsp/glsp/issues/153 Signed-off-by: Martin Fleck <mfleck@eclipsesource.com>
This was referenced Dec 1, 2020
Merged
Merged
martin-fleck-at
added a commit
to eclipse-glsp/glsp-client
that referenced
this issue
Dec 1, 2020
- Introduce dedicated 'NavigateToExternalTarget' action - Replace external target service with action handler Part of eclipse-glsp/glsp/issues/153 Signed-off-by: Martin Fleck <mfleck@eclipsesource.com>
martin-fleck-at
added a commit
to eclipse-glsp/glsp-server
that referenced
this issue
Dec 1, 2020
- Introduce dedicated 'NavigateToExternalTarget' action - Fix issue with wrong field name in 'NavigateToTarget' action Part of eclipse-glsp/glsp/issues/153 Signed-off-by: Martin Fleck <mfleck@eclipsesource.com>
martin-fleck-at
added a commit
that referenced
this issue
Dec 1, 2020
) * #153: Improve external navigation support through dedicated action - Add new NavigateToExternalTargetAction to protocol Part of /issues/153 Signed-off-by: Martin Fleck <mfleck@eclipsesource.com> Co-authored-by: Philip Langer <planger@users.noreply.github.com>
martin-fleck-at
added a commit
to eclipse-glsp/glsp-theia-integration
that referenced
this issue
Dec 1, 2020
* #153: Improve external navigation support through dedicated action - Replace TheiaNavigateToTargetHandler service with action handler - Refactor: Provide GLSP-Theia diagram configuration base class Part of eclipse-glsp/glsp/issues/153 Signed-off-by: Martin Fleck <mfleck@eclipsesource.com>
martin-fleck-at
added a commit
to eclipse-glsp/glsp-server
that referenced
this issue
Dec 1, 2020
Part of eclipse-glsp/glsp/issues/153 Signed-off-by: Martin Fleck <mfleck@eclipsesource.com>
martin-fleck-at
added a commit
that referenced
this issue
Dec 1, 2020
Signed-off-by: Martin Fleck <mfleck@eclipsesource.com>
tortmayr
pushed a commit
that referenced
this issue
Dec 1, 2020
…155) Signed-off-by: Martin Fleck <mfleck@eclipsesource.com>
tortmayr
pushed a commit
to eclipse-glsp/glsp-server
that referenced
this issue
Dec 1, 2020
Part of eclipse-glsp/glsp/issues/153 Signed-off-by: Martin Fleck <mfleck@eclipsesource.com>
|
@martin-fleck-at Can this be closed? |
|
Yes, all related PRs have been merged, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
At the moment we use a dedicated
ExternalNavigateToTargetHandlerclass to handle external navigation when a navigation target cannot be resolved or is outside the scope of the resource. Using such a handler, however, imposes some limits on the navigation framework. The main drawback is that we cannot support external navigation through the server easily. I therefore propose to replace the external handler with aNavigateToExternalTargetActionand handle the action like any other action (client or server).The text was updated successfully, but these errors were encountered: