Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#153: Improve external navigation support through dedicated action #95

Merged
merged 1 commit into from
Dec 1, 2020

Conversation

martin-fleck-at
Copy link
Contributor

  • Introduce dedicated 'NavigateToExternalTarget' action
  • Replace external target service with action handler

Part of eclipse-glsp/glsp/issues/153

Signed-off-by: Martin Fleck mfleck@eclipsesource.com

- Introduce dedicated 'NavigateToExternalTarget' action
- Replace external target service with action handler

Part of eclipse-glsp/glsp/issues/153

Signed-off-by: Martin Fleck <mfleck@eclipsesource.com>
Copy link
Member

@planger planger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, this makes the external navigation way more flexible! Thanks Martin!

@martin-fleck-at martin-fleck-at merged commit 83b3785 into master Dec 1, 2020
@martin-fleck-at martin-fleck-at deleted the issues/153 branch December 1, 2020 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants