Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for n:m communciation (multiple senders on a topic / CaProID) #25

Closed
13 tasks done
budrus opened this issue Dec 16, 2019 · 3 comments · Fixed by #84 or #102
Closed
13 tasks done

Support for n:m communciation (multiple senders on a topic / CaProID) #25

budrus opened this issue Dec 16, 2019 · 3 comments · Fixed by #84 or #102
Assignees
@mossmaurice @budrus
Labels
enhancement New feature
Milestone
High prio

Comments

@budrus
Copy link
Contributor

budrus commented Dec 16, 2019 •
edited
Loading

Brief feature description

Currently for each CaProID only one sender is allowed. This shall be extended to support m:n communication.

Detailed information

ROS2 is based on the DDS communication philosophy. In contrast to AUTOSAR, it is allowed that several publishers are writing to the same topic. This is currently not fully supported in iceoryx. For this feature the receiver ports must support multi-pusher queues.
To be more flexible for different communication patterns, we will have a bigger refactoring. Also the iceoryx public API will be affected

  • chunk queue building block

  • chunk distributor building block

  • chunk sender building block

  • chunk receiver building blocks

  • publisher port

  • subscriber port for single producer

  • condition variable

  • Integration of condition variable in existing building blocks

  • MPMC queue and integration in variant queue + harmonization of queue interfaces and port interfaces

  • subscriber port for multi producer

  • adaptation of RouDi for managing new ports and condition variable

  • adaptation of public API

  • new examples and go live
@budrus budrus added the enhancement New feature label Dec 16, 2019
@elBoberido elBoberido mentioned this issue Jan 22, 2020
Closed
@budrus budrus mentioned this issue Mar 28, 2020
Closed
budrus added a commit that referenced this issue Mar 29, 2020
@budrus
iox-#25: first version of ChunkSender and first tests
c5d5675 
Signed-off-by: Poehnl Michael (CC-AD/ESW1) <michael.poehnl@de.bosch.com>
budrus added a commit to budrus/iceoryx that referenced this issue Mar 29, 2020
@budrus
iox-eclipse-iceoryx#25: first version of ChunkSender and first tests
b68e1ed 
Signed-off-by: Poehnl Michael (CC-AD/ESW1) <michael.poehnl@de.bosch.com>
budrus added a commit to budrus/iceoryx that referenced this issue Mar 30, 2020
@budrus
iox-eclipse-iceoryx#25: more test for ChunkSender
572be49 
Signed-off-by: Poehnl Michael (CC-AD/ESW1) <michael.poehnl@de.bosch.com>
budrus added a commit to budrus/iceoryx that referenced this issue Mar 30, 2020
@budrus
iox-eclipse-iceoryx#25: finalized CHunkSender tests
b3076d3 
Signed-off-by: Poehnl Michael (CC-AD/ESW1) <michael.poehnl@de.bosch.com>
budrus added a commit to budrus/iceoryx that referenced this issue Mar 30, 2020
@budrus
iox-eclipse-iceoryx#25: some cleanup
052cb6f 
Signed-off-by: Poehnl Michael (CC-AD/ESW1) <michael.poehnl@de.bosch.com>
budrus added a commit to budrus/iceoryx that referenced this issue Apr 2, 2020
@budrus
iox-eclipse-iceoryx#25: some comments on background and future tasks
ea2725c 
Signed-off-by: Poehnl Michael (CC-AD/ESW1) <michael.poehnl@de.bosch.com>
@budrus budrus mentioned this issue Apr 2, 2020
Merged
budrus added a commit to budrus/iceoryx that referenced this issue Apr 3, 2020
@budrus
iox-eclipse-iceoryx#25: review findings
0f6e9e3 
Signed-off-by: Poehnl Michael (CC-AD/ESW1) <michael.poehnl@de.bosch.com>
budrus added a commit to budrus/iceoryx that referenced this issue Apr 4, 2020
@budrus
iox-eclipse-iceoryx#25: first version chunk receiver data
052f86e 
Signed-off-by: Poehnl Michael (CC-AD/ESW1) <michael.poehnl@de.bosch.com>
budrus added a commit to budrus/iceoryx that referenced this issue Apr 6, 2020
@budrus
iox-eclipse-iceoryx#25: some review findings
5a9fdc7 
Signed-off-by: Poehnl Michael (CC-AD/ESW1) <michael.poehnl@de.bosch.com>
budrus added a commit that referenced this issue Apr 6, 2020
@budrus
Merge pull request #81 from budrus/iox-#25-chunk-sender-and-receiver-…
f777d22 
…building-blocks

Iox #25 chunk sender building block
budrus added a commit to budrus/iceoryx that referenced this issue Apr 6, 2020
@budrus
iox-eclipse-iceoryx#25: first skeletons for chunk receiver and its test
33548dd 
Signed-off-by: Poehnl Michael (CC-AD/ESW1) <michael.poehnl@de.bosch.com>
budrus added a commit to budrus/iceoryx that referenced this issue Apr 6, 2020
@budrus
iox-eclipse-iceoryx#25: chunk receiver and first tests
a943543 
Signed-off-by: Poehnl Michael (CC-AD/ESW1) <michael.poehnl@de.bosch.com>
budrus added a commit to budrus/iceoryx that referenced this issue Apr 8, 2020
@budrus
iox-eclipse-iceoryx#25: more chunk receiver tests
dd4d8a6 
Signed-off-by: Poehnl Michael (CC-AD/ESW1) <michael.poehnl@de.bosch.com>
budrus added a commit to budrus/iceoryx that referenced this issue Apr 13, 2020
@budrus
iox-eclipse-iceoryx#25: some cosmetics
0dd4f60 
Signed-off-by: Poehnl Michael (CC-AD/ESW1) <michael.poehnl@de.bosch.com>
mossmaurice added a commit to mossmaurice/iceoryx that referenced this issue Apr 14, 2020
@mossmaurice
iox-eclipse-iceoryx#25 Update documentation on RouDi config file
6da1560 
Signed-off-by: Hoinkis Simon (CC-AD/ESW1) <simon.hoinkis2@de.bosch.com>
mossmaurice added a commit to mossmaurice/iceoryx that referenced this issue Apr 14, 2020
@mossmaurice
iox-eclipse-iceoryx#25 Add empty file for chunk building blocks integ…
70f4c7a 
…ration test

Signed-off-by: Hoinkis Simon (CC-AD/ESW1) <simon.hoinkis2@de.bosch.com>
mossmaurice added a commit to mossmaurice/iceoryx that referenced this issue Apr 14, 2020
@mossmaurice
iox-eclipse-iceoryx#25 Add three threads to building block integratio…
ffbff44 
…n test

Signed-off-by: Hoinkis Simon (CC-AD/ESW1) <simon.hoinkis2@de.bosch.com>
budrus added a commit to budrus/iceoryx that referenced this issue Apr 14, 2020
@budrus
iox-eclipse-iceoryx#25: review findings
dfbfa43 
Signed-off-by: Poehnl Michael (CC-AD/ESW1) <michael.poehnl@de.bosch.com>
mossmaurice added a commit to mossmaurice/iceoryx that referenced this issue Apr 20, 2020
@mossmaurice
Merge remote-tracking branch 'michael/iox-#25-chunk-receiver-building…
7dcc0e2 
…-block' into iox-eclipse-iceoryx#25-communication-setup-with-chunk-building-blocks-integration-test
mossmaurice added a commit to mossmaurice/iceoryx that referenced this issue Apr 20, 2020
@mossmaurice
iox-eclipse-iceoryx#25 Implement three threads for building block int…
c38ebd1 
…egration test

Signed-off-by: Hoinkis Simon (CC-AD/ESW1) <simon.hoinkis2@de.bosch.com>
mossmaurice added a commit to mossmaurice/iceoryx that referenced this issue Apr 20, 2020
@mossmaurice
iox-eclipse-iceoryx#25 Move the content of the methods to free functi…
e37ae4a 
…ons and make everything global

Signed-off-by: Hoinkis Simon (CC-AD/ESW1) <simon.hoinkis2@de.bosch.com>
@budrus budrus changed the title Support for multiple senders on a topic / CaProID Support for n:m communciation (multiple senders on a topic / CaProID) Apr 20, 2020
This was referenced Apr 22, 2020
Merged
Closed
mossmaurice added a commit to mossmaurice/iceoryx that referenced this issue May 6, 2020
@mossmaurice
iox-eclipse-iceoryx#25 Removed unused variable in chunk building bloc…
d12a268 
…k test

Signed-off-by: Hoinkis Simon (CC-AD/ESW1) <simon.hoinkis2@de.bosch.com>
mossmaurice added a commit to mossmaurice/iceoryx that referenced this issue May 7, 2020
@mossmaurice
iox-eclipse-iceoryx#25 Add random sleeps to make threads breathe
6053090 
Signed-off-by: Hoinkis Simon (CC-AD/ESW1) <simon.hoinkis2@de.bosch.com>
mossmaurice added a commit to mossmaurice/iceoryx that referenced this issue Sep 23, 2020
@mossmaurice
iox-eclipse-iceoryx#25 Fix build script
25e1dbe 
Signed-off-by: Hoinkis Simon (CC-AD/ESW1) <simon.hoinkis2@de.bosch.com>
elfenpiff added a commit to elfenpiff/iceoryx that referenced this issue Sep 23, 2020
@elfenpiff
iox-eclipse-iceoryx#25 added publisher and subscriber to discovery loop
abfe6a9 
Signed-off-by: Christian Eltzschig <christian.eltzschig2@de.bosch.com>
mossmaurice added a commit to mossmaurice/iceoryx that referenced this issue Sep 23, 2020
@mossmaurice
iox-eclipse-iceoryx#25 Address review findings
c7349f3 
Signed-off-by: Hoinkis Simon (CC-AD/ESW1) <simon.hoinkis2@de.bosch.com>
mossmaurice added a commit to mossmaurice/iceoryx that referenced this issue Sep 23, 2020
@mossmaurice
iox-eclipse-iceoryx#25 Address more review findings
8c9c429 
Signed-off-by: Hoinkis Simon (CC-AD/ESW1) <simon.hoinkis2@de.bosch.com>
mossmaurice added a commit to mossmaurice/iceoryx that referenced this issue Sep 23, 2020
@mossmaurice
iox-eclipse-iceoryx#25 Fix unused variable in doesViolateCommunicatio…
da8662a 
…nPolicy()

Signed-off-by: Hoinkis Simon (CC-AD/ESW1) <simon.hoinkis2@de.bosch.com>
elfenpiff added a commit to elfenpiff/iceoryx that referenced this issue Sep 23, 2020
@elfenpiff
iox-eclipse-iceoryx#25 refactored wait set and reduced complexity
ca4c4ac 
Signed-off-by: Eltzschig Christian (CC-AD/ESW1) <christian.eltzschig2@de.bosch.com>
elfenpiff added a commit to elfenpiff/iceoryx that referenced this issue Sep 23, 2020
@elfenpiff
iox-eclipse-iceoryx#25 removed unused enum
260a327 
Signed-off-by: Eltzschig Christian (CC-AD/ESW1) <christian.eltzschig2@de.bosch.com>
mossmaurice added a commit that referenced this issue Sep 23, 2020
@mossmaurice
Merge pull request #292 from mossmaurice/iox-#25-implement-unique-pub…
f34451c 
…lisher-detection

Iox #25 implement unique publisher detection for new building blocks
elfenpiff added a commit to elfenpiff/iceoryx that referenced this issue Sep 23, 2020
@elfenpiff
iox-eclipse-iceoryx#25 correct trigger handling in c subscriber
a97ea72 
Signed-off-by: Christian Eltzschig <christian.eltzschig2@de.bosch.com>
elfenpiff added a commit to elfenpiff/iceoryx that referenced this issue Sep 23, 2020
@elfenpiff
iox-eclipse-iceoryx#25 waitset is finally working
374a598 
Signed-off-by: Christian Eltzschig <christian.eltzschig2@de.bosch.com>
elfenpiff added a commit to elfenpiff/iceoryx that referenced this issue Sep 23, 2020
@elfenpiff
iox-eclipse-iceoryx#25 refactored semaphore to handle errors better
3df31d1 
Signed-off-by: Christian Eltzschig <christian.eltzschig2@de.bosch.com>
elfenpiff added a commit to elfenpiff/iceoryx that referenced this issue Sep 23, 2020
@elfenpiff
iox-eclipse-iceoryx#25 semaphore returns expected for all public meth…
a10ecb5 
…ods so that the user has a chance to perform a reasonable error handling

Signed-off-by: Christian Eltzschig <christian.eltzschig2@de.bosch.com>
elfenpiff added a commit to elfenpiff/iceoryx that referenced this issue Sep 23, 2020
@elfenpiff
iox-eclipse-iceoryx#25 adjusted semaphore constructor so that an addi…
15b2508 
…tional argument shows what the ctor is really doing

Signed-off-by: Christian Eltzschig <christian.eltzschig2@de.bosch.com>
elfenpiff added a commit to elfenpiff/iceoryx that referenced this issue Sep 23, 2020
@elfenpiff
iox-eclipse-iceoryx#25 removed [not yet implemented] from readme
955a799 
Signed-off-by: Christian Eltzschig <christian.eltzschig2@de.bosch.com>
orecham added a commit to elfenpiff/iceoryx that referenced this issue Sep 25, 2020
@orecham
iox-eclipse-iceoryx#25 Use new semaphore API in iceoryx_dds.
7b65338 
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <jeff.ithier@de.bosch.com>
elfenpiff added a commit to elfenpiff/iceoryx that referenced this issue Sep 28, 2020
@elfenpiff
iox-eclipse-iceoryx#25 renamed c example from on c to in c
ac32b63 
Signed-off-by: Eltzschig Christian (CC-AD/ESW1) <christian.eltzschig2@de.bosch.com>
elfenpiff added a commit to elfenpiff/iceoryx that referenced this issue Sep 29, 2020
@elfenpiff
iox-eclipse-iceoryx#25 fixed segfault in mac os semaphore
00a7013 
Signed-off-by: Christian Eltzschig <christian.eltzschig2@de.bosch.com>
elfenpiff added a commit to elfenpiff/iceoryx that referenced this issue Sep 29, 2020
@elfenpiff
iox-eclipse-iceoryx#25 better error handling in TriggerQueue
5ea18ca 
Signed-off-by: Christian Eltzschig <christian.eltzschig2@de.bosch.com>
elfenpiff added a commit to elfenpiff/iceoryx that referenced this issue Sep 29, 2020
@elfenpiff
iox-eclipse-iceoryx#25 removed gnu deprecated keyword and turned it i…
bbbf746 
…nto a doxygen comment

Signed-off-by: Christian Eltzschig <christian.eltzschig2@de.bosch.com>
elfenpiff added a commit to elfenpiff/iceoryx that referenced this issue Sep 30, 2020
@elfenpiff
iox-eclipse-iceoryx#25 capital letter U for unsigned integers
d389a40 
Signed-off-by: Christian Eltzschig <christian.eltzschig2@de.bosch.com>
elfenpiff added a commit that referenced this issue Sep 30, 2020
@elfenpiff
Merge pull request #310 from elfenpiff/iox-#25-service-discovery-for-…
785d3bd 
…new-building-blocks

Iox #25 service discovery for new building blocks
@evshary evshary mentioned this issue Oct 29, 2020
Closed
orecham added a commit to orecham/iceoryx that referenced this issue Nov 2, 2020
@orecham
Merge branch 'iox-eclipse-iceoryx#25-service-discovery-for-new-buildi…
3d93132 
…ng-blocks' into iox-eclipse-iceoryx#252-switch-to-new-api
@mossmaurice mossmaurice added this to the Release v1.0 milestone Nov 3, 2020
@mossmaurice
Copy link
Contributor

Will be continued in #252

@mossmaurice mossmaurice added this to Done in v1.0 Nov 4, 2020
@mossmaurice mossmaurice removed this from Done in v1.0 Nov 4, 2020
elfenpiff pushed a commit that referenced this issue Jul 7, 2022
@FerdinandSpitzschnueffler
Merge pull request #25 from ApexAI/iox-#1196-fix-string-warnings
07da0f1 
iox-#1196 fix string warnings
@VJonasHolley VJonasHolley mentioned this issue Nov 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mossmaurice mossmaurice

@budrus budrus

Labels
enhancement New feature
Projects
None yet
Milestone
High prio
2 participants
@mossmaurice @budrus