Iox #25 service discovery for new building blocks #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Eltzschig <christian.eltzschig2@de.bosch.com>
Signed-off-by: Eltzschig Christian (CC-AD/ESW1) <christian.eltzschig2@de.bosch.com>
Signed-off-by: Eltzschig Christian (CC-AD/ESW1) <christian.eltzschig2@de.bosch.com>
Signed-off-by: Christian Eltzschig <christian.eltzschig2@de.bosch.com>
Signed-off-by: Christian Eltzschig <christian.eltzschig2@de.bosch.com>
Signed-off-by: Christian Eltzschig <christian.eltzschig2@de.bosch.com>
…ods so that the user has a chance to perform a reasonable error handling Signed-off-by: Christian Eltzschig <christian.eltzschig2@de.bosch.com>
…tional argument shows what the ctor is really doing Signed-off-by: Christian Eltzschig <christian.eltzschig2@de.bosch.com>
Signed-off-by: Christian Eltzschig <christian.eltzschig2@de.bosch.com>
elfenpiff
requested review from
mossmaurice,
dkroenke,
budrus,
elBoberido and
MatthiasKillat
orecham
reviewed
Sep 24, 2020
elBoberido
previously requested changes
Sep 24, 2020
iceoryx_utils/include/iceoryx_utils/internal/concurrent/trigger_queue.inl
Outdated
Show resolved
Hide resolved
budrus
reviewed
Sep 24, 2020
Signed-off-by: Ithier Jeff (CC-AD/EYF1) <jeff.ithier@de.bosch.com>
marthtz
reviewed
Sep 25, 2020
Signed-off-by: Eltzschig Christian (CC-AD/ESW1) <christian.eltzschig2@de.bosch.com>
Signed-off-by: Christian Eltzschig <christian.eltzschig2@de.bosch.com>
Signed-off-by: Christian Eltzschig <christian.eltzschig2@de.bosch.com>
…nto a doxygen comment Signed-off-by: Christian Eltzschig <christian.eltzschig2@de.bosch.com>
budrus
previously approved these changes
Sep 29, 2020
mossmaurice
previously approved these changes
Sep 30, 2020
| @@ -89,12 +89,47 @@ void WaitSet::detachAllConditions() noexcept | |||
|
|
|||
| WaitSet::ConditionVector WaitSet::timedWait(const units::Duration timeout) noexcept | |||
| { | |||
| return waitAndReturnFulfilledConditions<WaitPolicy::TIMED_WAIT>(cxx::make_optional<units::Duration>(timeout)); | |||
| return waitAndReturnFulfilledConditions([this, timeout] { return !m_conditionVariableWaiter.timedWait(timeout); }); | |||
dkroenke
requested changes
Sep 30, 2020
| @@ -47,7 +47,7 @@ class ShutdownManager | |||
| static std::atomic_bool s_shutdownRequested; | |||
| ShutdownManager() = default; | |||
| }; | |||
| iox::posix::Semaphore ShutdownManager::s_semaphore = iox::posix::Semaphore::create(0u).get_value(); | |||
| iox::posix::Semaphore ShutdownManager::s_semaphore = iox::posix::Semaphore::create(iox::posix::CreateUnnamedSingleProcessSemaphore, 0u).get_value(); | |||
Signed-off-by: Christian Eltzschig <christian.eltzschig2@de.bosch.com>
budrus
approved these changes
Sep 30, 2020
dkroenke
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.