-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable clang-tidy checks and fix warnings in code #1196
Closed
85 tasks done
Labels
bugfix
Solves a bug
clang-tidy
Warning of a clang-tidy rule
globex
technical debt
unclean code and design flaws
Milestone
Comments
elfenpiff
added a commit
to ApexAI/iceoryx
that referenced
this issue
Jul 6, 2022
Signed-off-by: Christian Eltzschig <christian.eltzschig@apex.ai>
21 tasks
elfenpiff
added a commit
to ApexAI/iceoryx
that referenced
this issue
Jul 6, 2022
…ts and correct first part of cxx tests Signed-off-by: Christian Eltzschig <christian.eltzschig@apex.ai>
elfenpiff
added a commit
to ApexAI/iceoryx
that referenced
this issue
Jul 6, 2022
Signed-off-by: Christian Eltzschig <christian.eltzschig@apex.ai>
elfenpiff
added a commit
to ApexAI/iceoryx
that referenced
this issue
Jul 6, 2022
Signed-off-by: Christian Eltzschig <christian.eltzschig@apex.ai>
elfenpiff
added a commit
to ApexAI/iceoryx
that referenced
this issue
Jul 6, 2022
Signed-off-by: Christian Eltzschig <christian.eltzschig@apex.ai>
elfenpiff
added a commit
to ApexAI/iceoryx
that referenced
this issue
Jul 6, 2022
Signed-off-by: Christian Eltzschig <christian.eltzschig@apex.ai>
elfenpiff
added a commit
to ApexAI/iceoryx
that referenced
this issue
Jul 6, 2022
Signed-off-by: Christian Eltzschig <christian.eltzschig@apex.ai>
elfenpiff
added a commit
to ApexAI/iceoryx
that referenced
this issue
Jul 6, 2022
Signed-off-by: Christian Eltzschig <christian.eltzschig@apex.ai>
elfenpiff
added a commit
to ApexAI/iceoryx
that referenced
this issue
Jul 6, 2022
Signed-off-by: Christian Eltzschig <christian.eltzschig@apex.ai>
21 tasks
elfenpiff
added a commit
to ApexAI/iceoryx
that referenced
this issue
Jul 6, 2022
Signed-off-by: Christian Eltzschig <christian.eltzschig@apex.ai>
elfenpiff
added a commit
that referenced
this issue
Jul 6, 2022
…in-binding-c-tests iox-#1196 Fix compiler warnings in binding c tests
FerdinandSpitzschnueffler
added a commit
to ApexAI/iceoryx
that referenced
this issue
Jul 6, 2022
Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
21 tasks
elfenpiff
added a commit
to ApexAI/iceoryx
that referenced
this issue
Jul 6, 2022
…make STACK_SIZE in test uint64_t again Signed-off-by: Christian Eltzschig <christian.eltzschig@apex.ai>
FerdinandSpitzschnueffler
added a commit
to ApexAI/iceoryx
that referenced
this issue
Jul 6, 2022
Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
elfenpiff
added a commit
to ApexAI/iceoryx
that referenced
this issue
Jul 6, 2022
Signed-off-by: Christian Eltzschig <christian.eltzschig@apex.ai>
FerdinandSpitzschnueffler
added a commit
to ApexAI/iceoryx
that referenced
this issue
Jul 6, 2022
Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
elfenpiff
added a commit
to ApexAI/iceoryx
that referenced
this issue
Jul 6, 2022
Signed-off-by: Christian Eltzschig <christian.eltzschig@apex.ai>
elfenpiff
added a commit
to ApexAI/iceoryx
that referenced
this issue
Jul 6, 2022
Signed-off-by: Christian Eltzschig <christian.eltzschig@apex.ai>
elfenpiff
added a commit
to ApexAI/iceoryx
that referenced
this issue
Jul 6, 2022
Signed-off-by: Christian Eltzschig <christian.eltzschig@apex.ai>
FerdinandSpitzschnueffler
added a commit
to ApexAI/iceoryx
that referenced
this issue
Jul 6, 2022
Signed-off-by: Marika Lehmann <marika.lehmann@apex.ai>
elfenpiff
added a commit
to ApexAI/iceoryx
that referenced
this issue
Aug 23, 2022
…fully usable for robust mutex, address review findings Signed-off-by: Christian Eltzschig <me@elchris.org>
elfenpiff
added a commit
to ApexAI/iceoryx
that referenced
this issue
Aug 24, 2022
Signed-off-by: Christian Eltzschig <me@elchris.org>
elfenpiff
added a commit
to ApexAI/iceoryx
that referenced
this issue
Aug 24, 2022
Signed-off-by: Christian Eltzschig <me@elchris.org>
elfenpiff
added a commit
that referenced
this issue
Aug 24, 2022
…r-concurrent Iox #1196 activate clang tidy for concurrent
This was referenced Sep 7, 2022
Closed
elfenpiff
added a commit
to ApexAI/iceoryx
that referenced
this issue
Sep 12, 2022
…fully usable for robust mutex, address review findings Signed-off-by: Christian Eltzschig <me@elchris.org>
elfenpiff
added a commit
to ApexAI/iceoryx
that referenced
this issue
Sep 21, 2022
…fully usable for robust mutex, address review findings Signed-off-by: Christian Eltzschig <me@elchris.org>
elfenpiff
added a commit
to ApexAI/iceoryx
that referenced
this issue
Sep 22, 2022
…fully usable for robust mutex, address review findings Signed-off-by: Christian Eltzschig <me@elchris.org>
elBoberido
added a commit
to ApexAI/iceoryx
that referenced
this issue
Nov 1, 2022
21 tasks
elBoberido
added a commit
that referenced
this issue
Nov 1, 2022
…tic-accessed-through-instance-rule iox-#1196 Disable readability-static-accessed-through-instance rule
mossmaurice
pushed a commit
that referenced
this issue
Jan 17, 2023
Signed-off-by: Christian Eltzschig <christian.eltzschig@apex.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bugfix
Solves a bug
clang-tidy
Warning of a clang-tidy rule
globex
technical debt
unclean code and design flaws
Brief feature description
At the moment a lot of clang-tidy checks in our root
.clang-tidy
file are disabled to ensure that our codebase is at least warning free with a minimal subset of clang-tidy checks.We should enable the disabled checks one by one and solve the generated warnings in the same step. Some of the warnings require a larger refactoring. If this happens please create another issue and add a todo link in this issue.
ToDo
CMakeLists.txt
and the entryset(TEST_CXX_FLAGS PRIVATE ${ICEORYX_WARNINGS} ${ICEORYX_SANITIZER_FLAGS} -Wno-pedantic -Wno-conversion)
and fix all warnings..clang-tidy
file in every test disables warning which originate from the googletest fixtures itself. For instanceTEST_F
andTYPED_TEST
have a rule of 5 warning.Hints
The
.clang-tidy
file may have warnings which do not fit for us. If this is the case then please disable the warning and write a justification why this is rule is not appropriate. Example:CI checks
iceoryx_hoofs
diff checkscxx
@elfenpiffconcurrent
@elfenpiffdesign_pattern
@elfenpiffposix_wrapper
@elfenpiffunits
@elfenpifficeoryx_hoofs
full nightly scan based on.clang-tidy-diff-scans.txt
@elfenpiffFiles
When a file is stated, it means the header, inline file, cpp file and also the tests are refined.
iceoryx_hoofs/cxx
adaptive_wait
@elfenpiffalgorithm
@elfenpiffattributes.hpp
@elfenpiff (muahahha there were no warnings but it still counts!)convert
@elfenpiffdeadline_timer
@elfenpiffexpected
@elfenpifffile_reader
@FerdinandSpitzschnuefflerfilesystem
@elfenpiffforward_list
@FerdinandSpitzschnuefflerfunction_ref
@mossmauricefunction
@elfenpifffunctional_interface
@elfenpiffgeneric_raii
@elfenpiffhelplets
@elfenpifflist
@elfenpiffnewtype
@elBoberidooptional
@FerdinandSpitzschnuefflerpair
@elfenpiffpoor_mans_heap
@elBoberidoreference_counter
@elfenpiffrequires
@elfenpiffscoped_static
@elfenpiffserialization
@elBoberidoset
@elfenpiffstatic_storage
@elfenpiffstack
@elBoberidostorable_function
@elfenpiffstring
@FerdinandSpitzschnuefflertypes
@elBoberidotype_traits
@elfenpiffunique_id
@elfenpiffunique_ptr
@mossmauricevariant
@mossmauricevariant_queue
@FerdinandSpitzschnuefflervector
@mossmauriceiceoryx_hoofs/units
duration
@elBoberidoiceoryx_hoofs/concurrent
lockfree_queue
complete folder + header @MatthiasKillatactive_object
(ignore because it's obsolete?)fifo
@FerdinandSpitzschnuefflerloffli
@FerdinandSpitzschnuefflerperiodic_task
@FerdinandSpitzschnuefflersmart_lock
@FerdinandSpitzschnuefflersofi
@FerdinandSpitzschnuefflertaco
@FerdinandSpitzschnuefflertrigger_queue
(no warnings to fix)iceoryx_hoofs/rp
PointerRepository
@mossmauriceRelativePointer
@mossmauriceBaseRelativePointer
@mossmauriceRelativePointerData
@mossmauricerelocatable_ptr
@MatthiasKillatposix_wrapper
access_control
@elfenpifffile_lock
@elfenpiffipc_channel
@elfenpiffmessage_queue
@elfenpiffmutex
@elfenpiffnamed_pipe
@elfenpiffnamed_semaphore
@elfenpiffposix_access_rights
@elfenpiffposix_call
@elfenpiffsemaphore_interface
@elfenpiffsignal_handler
@elfenpiffsignal_watcher
@elfenpiffsystem_configuration
@FerdinandSpitzschnuefflerthread
@FerdinandSpitzschnuefflertypes
@FerdinandSpitzschnuefflerunix_domain_socket
@FerdinandSpitzschnuefflerunnamed_semaphore
@elfenpiffTODOs after merge of the integration branch
// NOLINTNEXTLINE (
operator<<
infilesystem.cpp
to reduce code complexityoperator std::string()
withtoStdString()
method #1612 removeoperator std::string()
fromcxx::string
and implementtoStdString
methodEXPECT_DEATH
#1613 removeEXPECT_DEATH
requires.hpp
with error handlercxx::convert
to handle allcxx::string
capacitiesclang-tidy
suppressions #1615 remove suppressions in code base for rules that are disabled in clang-tidy filestrerror_s
handling. Is only added to windows but must be added to platform libc layerduration
should use Newtype pattern to parameter mixupThe text was updated successfully, but these errors were encountered: