Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace usages of deprecated org.apache.commons.text.StrSubstitutor #571

Closed
rohanKanojia opened this issue Feb 9, 2021 · 3 comments · Fixed by #611
Closed

Replace usages of deprecated org.apache.commons.text.StrSubstitutor #571

rohanKanojia opened this issue Feb 9, 2021 · 3 comments · Fixed by #611
Assignees
@theexplorist
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@rohanKanojia
Copy link
Member

We are using StrSubstitutor from apache commons-lang at these places. But according to documentation[0], it's been marked as deprecated:

https://github.com/eclipse/jkube/blob/a70b19b6776f4e0c570053cc38913e031db4b0df/jkube-kit/build/service/docker/src/main/java/org/eclipse/jkube/kit/build/service/docker/WaitService.java#L150

https://github.com/eclipse/jkube/blob/a70b19b6776f4e0c570053cc38913e031db4b0df/jkube-kit/build/service/docker/src/main/java/org/eclipse/jkube/kit/build/service/docker/access/ContainerCreateConfig.java#L90

We should replace it with org.apache.commons.text.StringSubstitutor[1] instead.

[0] https://commons.apache.org/proper/commons-lang/apidocs/org/apache/commons/lang3/text/StrSubstitutor.html
[1] https://commons.apache.org/proper/commons-text/javadocs/api-release/org/apache/commons/text/StringSubstitutor.html
@rohanKanojia rohanKanojia added good first issue Good for newcomers help wanted Extra attention is needed labels Feb 9, 2021
@theexplorist
Copy link
Contributor

@rohanKanojia Hi rohan, please assign me this issue, will be sending the PR today itself.
Thank you

@rohanKanojia
Copy link
Member Author

@theexplorist : Hi Kartik, welcome back!

This was referenced Mar 11, 2021
Closed
Merged
@theexplorist
Copy link
Contributor

theexplorist commented Mar 12, 2021 •
edited
Loading

@rohanKanojia Thank you, Rohan! I am seeing to be a long time contributor here.
#611 All check are passed in this PR except eclipse even when i registered with it!
Please review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theexplorist theexplorist

Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace usages of deprecated StrSubstitutor
2 participants
@rohanKanojia @theexplorist