fixed non final variable code smell #1849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eclipse JKube CI ReportStarted new GH workflow run for #1849 (2022-10-16T14:35:08Z) ⚙️ JKube E2E Tests (3259749854)
|
Codecov Report
@@ Coverage Diff @@
## master #1849 +/- ##
============================================
+ Coverage 52.99% 53.00% +0.01%
- Complexity 3937 3938 +1
============================================
Files 464 464
Lines 20745 20744 -1
Branches 2809 2809
============================================
+ Hits 10993 10996 +3
+ Misses 8625 8622 -3
+ Partials 1127 1126 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Hi @manusa could you pass the PR? the CI is having some glitch |
getProgressBar was used by the first method, after deletion it too was referred as unused
|
Kudos, SonarCloud Quality Gate passed! |
manusa
reviewed
Oct 18, 2022
|
|
||
| // use port | ||
| //noinspection resource | ||
| ServerSocket ignored = new ServerSocket(foundPort); |
There was a problem hiding this comment.
This statement should be enclosed in a try-with-resources block so that the "ignored" port is closed when the test completes
manusa
reviewed
Oct 18, 2022
Comment on lines
+77
to
+84
| Exception exception = assertThrows(IllegalStateException.class, | ||
| () -> IoUtil.getFreeRandomPort(foundPort, foundPort, 3)); | ||
|
|
||
|
|
||
| String expectedMessage = "Cannot find a free random port in the range [" + foundPort + ", " + foundPort + "] after 3 attempts"; | ||
| String actualMessage = exception.getMessage(); | ||
|
|
||
| assertTrue(actualMessage.contains(expectedMessage)); |
There was a problem hiding this comment.
This could be converted to a single assertion using AssertJ
|
Thx for going for the extra mile, really appreciate it. I left a few comments that you can address (if you want) in a subsequent PR. |
|
Hi @manusa! I've fixed the issues and learned along the way (thanks for that 😉) should I create another PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1815
Type of change
Checklist