-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed non final variable code smell #1849
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d3d2929
fixed non final variable code smell
jhonDoe15 09680b6
fixed modifiers order to meet java standard
jhonDoe15 97951a4
clarified code segment
jhonDoe15 3e6a7f2
deleted project wide unused method (IntelliJ verified)
jhonDoe15 40259e9
revert method deletion
jhonDoe15 cb9d1a8
added tests to IoUtil
jhonDoe15 60ed861
replaced call with lambda and suppressed smells
jhonDoe15 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,9 +19,12 @@ | |
import org.junit.jupiter.api.Test; | ||
|
||
import static org.assertj.core.api.Assertions.assertThat; | ||
import static org.junit.jupiter.api.Assertions.assertThrows; | ||
import static org.junit.jupiter.api.Assertions.assertTrue; | ||
|
||
class IoUtilTest { | ||
|
||
|
||
@Test | ||
void findOpenPort() throws IOException { | ||
int port = IoUtil.getFreeRandomPort(); | ||
|
@@ -44,8 +47,46 @@ void findOpenPortWhenPortsAreBusy() throws IOException { | |
assertThat(port2).isGreaterThan(port); | ||
} | ||
|
||
@Test | ||
void findOpenPortWithSmallAttemptsCount() throws IOException { | ||
int port = IoUtil.getFreeRandomPort(30000, 60000, 30); | ||
try (ServerSocket ss = new ServerSocket(port)) { | ||
assertThat(ss).isNotNull(); | ||
} | ||
} | ||
|
||
@Test | ||
void findOpenPortWithLargeAttemptsCount() throws IOException { | ||
int port = IoUtil.getFreeRandomPort(30000, 60000, 1000); | ||
try (ServerSocket ss = new ServerSocket(port)) { | ||
assertThat(ss).isNotNull(); | ||
} | ||
} | ||
|
||
@Test | ||
void invokeExceptionWhenCouldntFindPort() throws IOException { | ||
|
||
// find open port to occupy | ||
int foundPort = IoUtil.getFreeRandomPort(30000, 65000, 1000); | ||
|
||
// use port | ||
//noinspection resource | ||
ServerSocket ignored = new ServerSocket(foundPort); | ||
|
||
// try to use the used port | ||
Exception exception = assertThrows(IllegalStateException.class, | ||
() -> IoUtil.getFreeRandomPort(foundPort, foundPort, 3)); | ||
|
||
|
||
String expectedMessage = "Cannot find a free random port in the range [" + foundPort + ", " + foundPort + "] after 3 attempts"; | ||
String actualMessage = exception.getMessage(); | ||
|
||
assertTrue(actualMessage.contains(expectedMessage)); | ||
Comment on lines
+77
to
+84
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This could be converted to a single assertion using AssertJ |
||
} | ||
|
||
@Test | ||
void testSanitizeFileName() { | ||
//noinspection ConstantConditions | ||
assertThat(IoUtil.sanitizeFileName(null)).isNull(); | ||
assertThat(IoUtil.sanitizeFileName("Hello/&%World")).isEqualTo("Hello-World"); | ||
assertThat(IoUtil.sanitizeFileName(" _H-.-e-.-l-l--.//o()")).isEqualTo("-H-e-l-l-o-"); | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This statement should be enclosed in a try-with-resources block so that the "ignored" port is closed when the test completes