Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update diagnostics for deleted files #1441

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Conversation

msujew
Copy link
Member

@msujew msujew commented Apr 5, 2024

Closes #1440

Simply replaces the diagnostics of all deleted files with an empty array, thereby unpublishing them. This effects both deleted and renamed files.

@msujew msujew added validation Validation related issue LSP Language Server Protocol integration labels Apr 5, 2024
Copy link
Contributor

@montymxb montymxb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:octocat: Looks good

@msujew msujew merged commit 29b57c2 into main Apr 8, 2024
5 checks passed
@msujew msujew deleted the msujew/delete-diagnostics branch April 8, 2024 08:17
@msujew msujew added this to the v3.1.0 milestone Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LSP Language Server Protocol integration validation Validation related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Diagnostics are stuck on deleted files
2 participants