Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple occurrences of sudo in run-leda.sh #54

Closed
razr opened this issue Mar 2, 2023 · 1 comment · Fixed by #58
Closed

multiple occurrences of sudo in run-leda.sh #54

razr opened this issue Mar 2, 2023 · 1 comment · Fixed by #58
Labels
bug Something isn't working

Comments

@razr
Copy link

razr commented Mar 2, 2023

Describe the bug
There are multiple occurrences of sudo in run-leda.sh which are undocumented. It is not transparent what this script is doing/could do with the machine after acquiring sudo privileges.

To Reproduce
Steps to reproduce the behaviour:

$ grep sudo ./run-leda.sh
TUNCTL="sudo tunctl"
IFCONFIG="sudo ip"
IPTABLES="sudo iptables"
    sudo bash -c "echo 1 > /proc/sys/net/ipv4/ip_forward"
    sudo bash -c "echo 1 > /proc/sys/net/ipv4/conf/$TAP/proxy_arp"
        echo "Do you wish to install $package using sudo?"
                    sudo apt-get install -y $package;
sudo qemu-system-x86_64 \

Expected behaviour
no sudo commands

Screenshots / Logfiles
If applicable, add screenshots to help explain your problem.

Leda Version (please complete the following information):

  • Version: 2022, 0.0.4
  • Machine: qemux86_64
  • Connectivity: no connectivity

Additional context
no

@razr razr added the bug Something isn't working label Mar 2, 2023
@mikehaller
Copy link
Contributor

We decided to remove all occurrences of sudo in the run-leda script and making it simpler.

If anybody wants to (or needs to) use a different type of network setup, a modification of the script is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants