Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applying Security Best Practices: SBOM plugin (#1360) #1361

Closed
wants to merge 1 commit into from
Closed

Applying Security Best Practices: SBOM plugin (#1360) #1361

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 24, 2023

Adding the CycloneDX Maven Plugin to the project's POM file.

resolve: #1360

Copy link
Member

@laeubi laeubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide example output and describe how this helps here as cyclone does not support Eclipse/Tycho build projects see:

@ghost
Copy link
Author

ghost commented Apr 24, 2023

Please provide example output and describe how this helps here as cyclone does not support Eclipse/Tycho build projects see:

Hi,

First at all, thanks for the feedback

Finally, please find attached a zip file with the output of local test related to the latest update,
bom.zip

Thanks,

@laeubi
Copy link
Member

laeubi commented Apr 25, 2023

@fperezel I'll try to take a look into this, it would be good to explain who is using this information, e.g. is it expected to be included as a resource in the final jar? If yes we might need to increase versions for all modules to make the change effective.

@ghost
Copy link
Author

ghost commented Apr 25, 2023

@fperezel I'll try to take a look into this, it would be good to explain who is using this information, e.g. is it expected to be included as a resource in the final jar? If yes we might need to increase versions for all modules to make the change effective.

Hi, answering first question about "who is using this information". I may say any consumer of the software according all recommendation and regulations related to BOM files

Regarding if it should be included as resource in the final jar. From my point of view, I do recommend to include BOM files in each final jar in order to any consumer of any of jar can check it.

Finally, I have pushed a final pom version file where CycloneDX goal has been update makeBom after tested out this option. So that could the latest pom file version and it is ready for reviewing for a possible merge.

Cheers

@ghost ghost marked this pull request as draft May 30, 2023 10:28
@ghost ghost closed this May 30, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Security Best Practices: CycloneDX Maven Plugin for generating SBOMs
1 participant