Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security Best Practices: CycloneDX Maven Plugin for generating SBOMs #1360

Open
ghost opened this issue Apr 24, 2023 · 5 comments
Open

Security Best Practices: CycloneDX Maven Plugin for generating SBOMs #1360

ghost opened this issue Apr 24, 2023 · 5 comments

Comments

@ghost
Copy link

ghost commented Apr 24, 2023

Hi,

As part of the ongoing effort to improve the security of the project from the Security Team of the Eclipse Foundation, we are adding the CycloneDX Maven Plugin to the project's POM file.

This plugin will help to generate a Software Bill of Materials (SBOM), which will provide greater visibility into the project's dependencies and enhance the overall security.

We welcome any feedback or questions about this update, so please don't hesitate to reach out if there are any concerns or if there's anything we can help with.

Thanks.

Kind Regards,
Francisco Perez

@laeubi
Copy link
Member

laeubi commented Apr 24, 2023

The plugin is known to not work well for Tycho / Eclipse projects and the maintainer are not planning to add support here, so I don't expect much value here for m2e or any Eclipse Project unless major partsa re moved to plain maven dependencies:

@ghost
Copy link
Author

ghost commented Apr 24, 2023

Hi @laeubi ,

Thanks, for the feed back, I am having a look into the issue pointed out as well as I have already updated the PR providing the outcome requested for the last commit.

I feel that regardless the cyclonedx may not suit for Tycho / Eclipse for this project provides a helpful information about all dependencies from security point of view, what do you think?

Kind Regards,

@laeubi
Copy link
Member

laeubi commented Apr 24, 2023

I think cyclone should at least support pkg:p2 as a type or otherwise this might give a false impression that m2e uses a lot less dependencies as it is actually the case.

Another question would be who is supposed to read that data? As m2e is mostly used inside Eclipse adding that data (should it become part of the jar?) seems a bit superfluous if there is no plan for Eclipse/P2 to read that data and do anything useful with it, and if used by maven these tools might have no idea about the pkg:p2 type...

@waynebeaton
Copy link
Contributor

Try adding -Dtycho.target.eager=true.

@ghost
Copy link
Author

ghost commented May 30, 2023

Hi,

Closed the PR #1361 due to currently we don't have a solution for tycho based builds. I am wondering if you prefer to keep this ticket open until we have a solution. Do you prefer to leave opened?

Thanks,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants