Abstract the delta handling from the resource API #1496
Merged
+222
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @martinlippert if you can check out the patch and see if it introduces any new problem it would be great. This is a very first step to improve the situation, we need to be able to further detect changes that are not seen by the resource API. |
laeubi
force-pushed
the
resource_handling
branch
from
44ab29f
to
103a1d6
Compare
@BoykoAlex 👆Maybe you can give this a try? |
Currently m2e is directly wired to the resource delta API, while this seems good in the context of eclipse for m2e this imposes to restrictive API as it is all noimplement/extend interfaces and offer much more than m2e actually using. This aims to implement a thin wrapper for further improvement of delta detection especially when it comes to resource see for example eclipse-m2e#1302 This will not fix anything but is an important first step to ensure things are still working as before.
laeubi
force-pushed
the
resource_handling
branch
from
103a1d6
to
a4869ce
Compare
|
Tests are green (except the usual macos) so lets give it a try so we can have additional PRs based on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently m2e is directly wired to the resource delta API, while this seems good in the context of eclipse for m2e this imposes to restrictive API as it is all noimplement/extend interfaces and offer much more than m2e actually using.
This aims to implement a thin wrapper for further improvement of delta detection especially when it comes to resource see for example #1302
This will not fix anything but is an important first step to ensure things are still working as before.