Support project local maven settings #1673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tivervac
reviewed
Feb 13, 2024
org.eclipse.m2e.core/src/org/eclipse/m2e/core/internal/embedder/MavenImpl.java
Outdated
Show resolved
Hide resolved
org.eclipse.m2e.core/src/org/eclipse/m2e/core/internal/embedder/MavenImpl.java
Outdated
Show resolved
Hide resolved
org.eclipse.m2e.core/src/org/eclipse/m2e/core/internal/embedder/MavenProperties.java
Outdated
Show resolved
Hide resolved
org.eclipse.m2e.core/src/org/eclipse/m2e/core/project/ISettingsFiles.java
Outdated
Show resolved
Hide resolved
org.eclipse.m2e.core/src/org/eclipse/m2e/core/project/ISettingsFiles.java
Outdated
Show resolved
Hide resolved
laeubi
force-pushed
the
support_project_local_settings
branch
3 times, most recently
from
a392a9f
to
81abdef
Compare
This was referenced Feb 14, 2024
laeubi
force-pushed
the
support_project_local_settings
branch
from
81abdef
to
24f394b
Compare
|
So now after some preliminary work this is finally ready and works to discover a changed local repository in the user and/or global settings! Another issue might be toolchain files, this seems only partly supported but is out of scope of this issue. |
laeubi
force-pushed
the
support_project_local_settings
branch
2 times, most recently
from
d9f13ef
to
f3f8e8c
Compare
tivervac
reviewed
Feb 14, 2024
org.eclipse.m2e.core/src/org/eclipse/m2e/core/internal/embedder/MavenExecutionContext.java
Outdated
Show resolved
Hide resolved
org.eclipse.m2e.core/src/org/eclipse/m2e/core/internal/embedder/MavenExecutionContext.java
Show resolved
Hide resolved
laeubi
force-pushed
the
support_project_local_settings
branch
from
f3f8e8c
to
c0a2496
Compare
Currently m2e has one global way to specify the global/user settings file, but one can also configure this through .mvn/maven.config files and while m2e already supports specification of properties and profiles there this does not work for (global)settings. This leads to the situation that user probably getting different results when running a mojo as part of eclipse or on the commandline. This now adds the infrastructure and support for projects having a local configuration as well by augmenting the maven.config if available.
laeubi
force-pushed
the
support_project_local_settings
branch
from
c0a2496
to
7500652
Compare
|
This improvement was gently sponsored by |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently m2e has one global way to specify the global/user settings file, but one can also configure this through .mvn/maven.config files and while m2e already supports specification of properties and profiles there this does not work for (global)settings. This leads to the situation that user probably getting different results when running a mojo as part of eclipse or on the commandline.
This now adds the infrastructure and support for projects having a local configuration as well by augmenting the maven.config if available.