Support loading of settings from other locations #1678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently there is only one cached settings object for the all projects but it is possible for projects to carry individual settings. This now enhances the settings handling in a way to support providing a composite key of global and local settings to be loaded an cached.
Test Results 214 files ±0 214 suites ±0 18m 6s ⏱️ - 3m 37s For more details on these failures, see this check. Results for commit 5cd92b0. ± Comparison against base commit f201544. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is only one cached settings object for the all projects but it is possible for projects to carry individual settings.
This now enhances the settings handling in a way to support providing a composite key of global and local settings to be loaded an cached.
This is split up from this:
to keep changes small in the actual PR