Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up extra ifdefs in runtime/include/j9lib.h.in #11174

Closed
sharon-wang opened this issue Nov 12, 2020 · 1 comment · Fixed by #11662
Closed

Clean up extra ifdefs in runtime/include/j9lib.h.in #11174

sharon-wang opened this issue Nov 12, 2020 · 1 comment · Fixed by #11662
Labels

Comments

@sharon-wang
Copy link
Contributor

Mentioned in review of #11166.

There are a bunch of duplicated DLL Name defines in j9lib.h.in, as per https://github.com/eclipse/openj9/blob/05e6d8f3fb20bb8278b146764bf88fd8de7f3f2a/runtime/include/j9lib.h.in#L68

We should look into removing the extra defines so the file can be cleaned up.

CC @keithc-ca @dnakamura

@sharon-wang
Copy link
Contributor Author

Thanks @dnakamura for the additional insight, from a review comment in #11166:

The comment /* We need certain defines... this is a big hack until we can do this another way.*/ is copied over from j9lib.h.ftl. It seems there may be some UMA limitation, where targets don't get picked up as part of:

<#list uma.spec.artifacts as artifact>
<#if artifact.data.dllDescription.present>
#define J9${artifact.data.dllDescription.underscored_data}_DLL_NAME "${artifact.targetNameWithRelease}"
</#if>
</#list>

It should be safe to delete the extra defines below the /* We need certain defines... this is a big hack until we can do this another way.*/ comment in j9lib.h.in.

It's also not necessary to keep extern "C" since there are only #defines in the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants