-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Jtreg/FFI] Disable FFI test suites in Jtreg test for JDK20 #16565
Comments
PR has been created at adoptium/aqa-tests#4251 to exclude all FFI specific test suites. |
Close this issue as adoptium/aqa-tests#4251 was merged. |
Unless I misunderstand, this should stay open in the jdk20 milestone plan as a reminder to un-exclude the tests later. |
The failing FFI related test case (in |
@ChengJin01 were these tests re-enabled? |
Not yet due to the issue with the heap segment in upcall at #16761. Will double-check everything in FFI Jtreg test suite to see what else is left assuming this is no platform dependent issue. |
There was a Jtreg test failure detected in JDK17/20 on some of platforms by #16761 which was caused by the null check on the pointer segment (which should be removed in the case of |
@ChengJin01 Any update on this? |
There is no code related issue except a test fix on AIX at ibmruntimes/openj9-openjdk-jdk20#49. Will double-check in Grinders before enabling the Jtreg suites once ibmruntimes/openj9-openjdk-jdk20#49 gets merged. |
The changes enable the FFI test suites in JDK20 and exclude them in JDK21 as the FFI specific code for JEP442 has not yet been completed. Fixes: #eclipse-openj9/openj9/issues/16565 Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
The changes enable the FFI test suites in JDK20 and exclude them in JDK21 as the FFI specific code for JEP442 has not yet been completed. Fixes: #eclipse-openj9/openj9/issues/16565 Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
Close this issue as the FFI test suites in JDK20 has been enabled via adoptium/aqa-tests#4591. |
Given the changes at ibmruntimes/openj9-openjdk-jdk#531 with updated APIs for JEP434 (#16329) will be merged to JDK20 only for compilation, in which case all FFI specific test suites in JDK20 at https://github.com/ibmruntimes/openj9-openjdk-jdk20/tree/openj9/test/jdk/java/foreign must be disabled via https://github.com/adoptium/aqa-tests for the moment till we update everything related to JEP434 in OpenJDK & OpenJ9.
The text was updated successfully, but these errors were encountered: