Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Jtreg/FFI] Disable FFI test suites in Jtreg test for JDK20 #16565

Closed
ChengJin01 opened this issue Jan 17, 2023 · 11 comments
Closed

[Jtreg/FFI] Disable FFI test suites in Jtreg test for JDK20 #16565

ChengJin01 opened this issue Jan 17, 2023 · 11 comments
Assignees
@ChengJin01
Labels
comp:vm jdk20 project:panama Used to track Project Panama related work
Milestone
Java 20.0.1 0.39

Comments

@ChengJin01
Copy link
Contributor

ChengJin01 commented Jan 17, 2023 •
edited
Loading

Given the changes at ibmruntimes/openj9-openjdk-jdk#531 with updated APIs for JEP434 (#16329) will be merged to JDK20 only for compilation, in which case all FFI specific test suites in JDK20 at https://github.com/ibmruntimes/openj9-openjdk-jdk20/tree/openj9/test/jdk/java/foreign must be disabled via https://github.com/adoptium/aqa-tests for the moment till we update everything related to JEP434 in OpenJDK & OpenJ9.
@ChengJin01
Copy link
Contributor Author

FYI: @tajila, @pshipton, @llxia

@ChengJin01 ChengJin01 added project:panama Used to track Project Panama related work test excluded jdk20 labels Jan 17, 2023
@ChengJin01
Copy link
Contributor Author

PR has been created at adoptium/aqa-tests#4251 to exclude all FFI specific test suites.

@ChengJin01
Copy link
Contributor Author

Close this issue as adoptium/aqa-tests#4251 was merged.

@pshipton pshipton added this to the Java 20 milestone Feb 8, 2023
@pshipton
Copy link
Member

pshipton commented Feb 8, 2023

Unless I misunderstand, this should stay open in the jdk20 milestone plan as a reminder to un-exclude the tests later.

@pshipton pshipton reopened this Feb 8, 2023
@ChengJin01
Copy link
Contributor Author

ChengJin01 commented Feb 8, 2023 •
edited
Loading

The failing FFI related test case (in java/lang/Thread/jni/AttachCurrentThread/AttachTest.java) captured at #16656 was excluded via adoptium/aqa-tests#4318. So we will enable all of them after we finish updating the code in OpenJDK & OpenJ9 against the latest APIs in JDK20.

@ChengJin01 ChengJin01 mentioned this issue Feb 8, 2023
Closed
@tajila
Copy link
Contributor

tajila commented Apr 25, 2023

@ChengJin01 were these tests re-enabled?

@ChengJin01
Copy link
Contributor Author

@ChengJin01 were these tests re-enabled?

Not yet due to the issue with the heap segment in upcall at #16761. Will double-check everything in FFI Jtreg test suite to see what else is left assuming this is no platform dependent issue.

@tajila tajila added the comp:vm label May 9, 2023
@ChengJin01
Copy link
Contributor Author

ChengJin01 commented May 15, 2023 •
edited
Loading

There was a Jtreg test failure detected in JDK17/20 on some of platforms by #16761 which was caused by the null check on the pointer segment (which should be removed in the case of vprintf). Currently I am verifying my fix at ChengJin01@84e15f2 to ensure it works good on the failing platforms.

@tajila
Copy link
Contributor

tajila commented May 23, 2023

@ChengJin01 Any update on this?

@ChengJin01
Copy link
Contributor Author

@ChengJin01 Any update on this?

There is no code related issue except a test fix on AIX at ibmruntimes/openj9-openjdk-jdk20#49. Will double-check in Grinders before enabling the Jtreg suites once ibmruntimes/openj9-openjdk-jdk20#49 gets merged.

ChengJin01 added a commit to ChengJin01/aqa-tests that referenced this issue May 29, 2023
@ChengJin01
[Jtreg/FFI] Enable the test suites in JDK20
2c09319 
The changes enable the FFI test suites in JDK20
and exclude them in JDK21 as the FFI specific
code for JEP442 has not yet been completed.

Fixes: #eclipse-openj9/openj9/issues/16565

Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
@ChengJin01 ChengJin01 mentioned this issue May 29, 2023
Merged
smlambert pushed a commit to adoptium/aqa-tests that referenced this issue May 29, 2023
@ChengJin01
[Jtreg/FFI] Enable the test suites in JDK20 (#4591)
d3376be 
The changes enable the FFI test suites in JDK20
and exclude them in JDK21 as the FFI specific
code for JEP442 has not yet been completed.

Fixes: #eclipse-openj9/openj9/issues/16565

Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
@ChengJin01
Copy link
Contributor Author

Close this issue as the FFI test suites in JDK20 has been enabled via adoptium/aqa-tests#4591.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChengJin01 ChengJin01

Labels
comp:vm jdk20 project:panama Used to track Project Panama related work
Projects
None yet
Milestone
Java 20.0.1 0.39
Development

No branches or pull requests
3 participants
@tajila @ChengJin01 @pshipton