-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Jtreg/FFI] Disable FFI related test suite in JDK20 #4318
Merged
smlambert
merged 1 commit into
adoptium:master
from
ChengJin01:exclude_ffi_attachtest_jdk20
Feb 8, 2023
Merged
[Jtreg/FFI] Disable FFI related test suite in JDK20 #4318
smlambert
merged 1 commit into
adoptium:master
from
ChengJin01:exclude_ffi_attachtest_jdk20
Feb 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change is to exclude the FFI related test cases in AttachTest.java captured at eclipse-openj9/openj9#16656 given the FFI related code in JDK20 has been disabled for the moment and will be enabled once the code has been updated against the latest APIs. Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
Reviewer: @llxia |
Grinder is launched at https://openj9-jenkins.osuosl.org/job/Grinder/1985/ to check the excluded test suite. |
The failing test cases in |
llxia
approved these changes
Feb 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
smlambert
approved these changes
Feb 8, 2023
sophia-guo
pushed a commit
to sophia-guo/openjdk-tests
that referenced
this pull request
Mar 10, 2023
The change is to exclude the FFI related test cases in AttachTest.java captured at eclipse-openj9/openj9#16656 given the FFI related code in JDK20 has been disabled for the moment and will be enabled once the code has been updated against the latest APIs. Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
sophia-guo
pushed a commit
to sophia-guo/openjdk-tests
that referenced
this pull request
Mar 10, 2023
The change is to exclude the FFI related test cases in AttachTest.java captured at eclipse-openj9/openj9#16656 given the FFI related code in JDK20 has been disabled for the moment and will be enabled once the code has been updated against the latest APIs. Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
smlambert
added a commit
that referenced
this pull request
Mar 10, 2023
* Set up jdk for jck interactive (#4239) * Set up jdk for jck interactive Signed-off-by: Sophia Guo <sophia.gwf@gmail.com> * Add parameter SETUP_JCK_RUN explicitely Signed-off-by: Sophia Guo <sophia.gwf@gmail.com> --------- Signed-off-by: Sophia Guo <sophia.gwf@gmail.com> * [Jtreg/FFI] Disable FFI related test suite in JDK20 (#4318) The change is to exclude the FFI related test cases in AttachTest.java captured at eclipse-openj9/openj9#16656 given the FFI related code in JDK20 has been disabled for the moment and will be enabled once the code has been updated against the latest APIs. Signed-off-by: ChengJin01 <jincheng@ca.ibm.com> * Fix if condition for tck interactive setup (#4320) Signed-off-by: Mesbah Alam <Mesbah_Alam@ca.ibm.com> * [Jtreg/FFI] update the issue no for FFI test suites in JDK20 (#4324) The change updates the issue no by replacing #16656 with #16565 as #16656 will be closed as duplicate of #16565, in which case #16565 serves as the only issue that keeps track of the excluded FFI test suites in JDK20. Signed-off-by: ChengJin01 <jincheng@ca.ibm.com> * Add OpenJ9 timeout handler to security and rmi extended tests (#4333) Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com> * Disable GetStackTraceSuspendedStressTest (#4360) Related: eclipse-openj9/openj9#16751 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com> * Update JDK20 exclude list (#4371) Re-enable Thread related tests fixed in JDK19 Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com> * Disable ContinuationTest (#4380) ContinuationTest is being disabled for OpenJ9 since it is specific to the reference implementation and it does not apply to OpenJ9. Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com> * Permanently disable ContinuationTest (#4382) Refer to #1297 to permanently exclude. Related: eclipse-openj9/openj9#16792 Related: #1297 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com> * Exclude jdk/internal/platform/docker/TestDockerCpuMetrics.java (#4387) Signed-off-by: Jason Feng <fengj@ca.ibm.com> * AUTO: auto exclude test jdk_svc_sanity plat=ppc64_aix impl=hotspot (#4389) - related: #4218 (comment) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: smlambert <smlambert@users.noreply.github.com> --------- Signed-off-by: Sophia Guo <sophia.gwf@gmail.com> Signed-off-by: ChengJin01 <jincheng@ca.ibm.com> Signed-off-by: Mesbah Alam <Mesbah_Alam@ca.ibm.com> Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com> Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com> Signed-off-by: Jack Lu <Jack.S.Lu@ibm.com> Signed-off-by: Jason Feng <fengj@ca.ibm.com> Signed-off-by: GitHub <noreply@github.com> Co-authored-by: Cheng Jin <jincheng@ca.ibm.com> Co-authored-by: Mesbah Alam <Mesbah_Alam@ca.ibm.com> Co-authored-by: Peter Shipton <Peter_Shipton@ca.ibm.com> Co-authored-by: Babneet Singh <babsingh@users.noreply.github.com> Co-authored-by: Jack Lu <Jack.S.Lu@ibm.com> Co-authored-by: Jason Feng <fengj@ca.ibm.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: smlambert <smlambert@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change is to exclude the FFI related test cases in AttachTest.java captured at
eclipse-openj9/openj9#16656 given the FFI related code
in JDK20 has been disabled for the moment and will be enabled once the code
has been updated against the latest APIs.
Signed-off-by: ChengJin01 jincheng@ca.ibm.com