Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stubs for Constants API (jep334) #4030

Merged
merged 1 commit into from Feb 14, 2019

Conversation

theresa-m
Copy link
Contributor

@theresa-m theresa-m commented Dec 13, 2018

This change adds the remaining method stubs for jep334 that were not directly needed to compile Java12 and adjusts interface implementation dependencies for Constable classes.

Java 12 depends on #3980 to compile (also see #4195)

Signed-off-by: Theresa Mammarella Theresa.T.Mammarella@ibm.com

@theresa-m
Copy link
Contributor Author

update copyrights

@theresa-m theresa-m changed the title Stubs for Constants API (jep 334) Stubs for Constants API (jep334) Jan 28, 2019
@pshipton pshipton added this to the Release 0.13.0 (Java 12) milestone Jan 28, 2019
@pshipton pshipton added this to In progress in JEP 334 via automation Jan 28, 2019
@pshipton
Copy link
Member

@pshipton
Copy link
Member

@pshipton
Copy link
Member

Copy link
Member

@DanHeidinga DanHeidinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DanHeidinga
Copy link
Member

@theresa-m Can you rebase and squash these two commits?

@DanHeidinga DanHeidinga self-assigned this Feb 14, 2019
@pshipton
Copy link
Member

Note these changes are required, either here or in another PR.

System.Logger.Level implements Constable
http://cr.openjdk.java.net/~iris/se/12/build/latest/api/java.base/java/lang/System.Logger.Level.html

Thread.State implements Constable
http://cr.openjdk.java.net/~iris/se/12/build/latest/api/java.base/java/lang/Thread.State.html

StackWalker.Option implements Constable
http://cr.openjdk.java.net/~iris/se/12/build/latest/api/java.base/java/lang/StackWalker.Option.html

@theresa-m
Copy link
Contributor Author

working on that. I'll add the extra extends here as well

@theresa-m
Copy link
Contributor Author

theresa-m commented Feb 14, 2019

actually I thought that because Enum already implements Constable that it wasn't necessary to add implements Constable to these explicitly. do you still want them included?

Signed-off-by: Theresa Mammarella <Theresa.T.Mammarella@ibm.com>
@pshipton
Copy link
Member

I thought that because Enum already implements Constable that it wasn't necessary to add implements Constable to these explicitly

Sounds good. I missed that because I was just looking at changes in the classes OpenJ9 implements.

@DanHeidinga
Copy link
Member

Jenkins test sanity zlinux jdk11

@DanHeidinga
Copy link
Member

Once the jdk11 sanity build passes, I'll merge this.

@DanHeidinga DanHeidinga merged commit b9bb3c0 into eclipse-openj9:master Feb 14, 2019
JEP 334 automation moved this from In progress to Done Feb 14, 2019
@theresa-m theresa-m deleted the jep334_stubs branch February 25, 2019 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
JEP 334
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants