Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Methods and tests for jep334 MethodType #4194

Merged
merged 2 commits into from Feb 23, 2019
Merged

Methods and tests for jep334 MethodType #4194

merged 2 commits into from Feb 23, 2019

Conversation

theresa-m
Copy link
Contributor

@theresa-m theresa-m commented Jan 8, 2019 •
edited

  • describeConstable
  • descriptorString

Depends on (see #4195):

Signed-off-by: Theresa Mammarella Theresa.T.Mammarella@ibm.com

@theresa-m theresa-m mentioned this pull request Jan 8, 2019
Closed
9 tasks
@theresa-m theresa-m mentioned this pull request Jan 23, 2019
Merged
@pshipton pshipton added this to the Release 0.13.0 (Java 12) milestone Jan 28, 2019
@pshipton pshipton added this to In progress in JEP 334 via automation Jan 28, 2019
@theresa-m theresa-m force-pushed the jep334_methodtype branch 2 times, most recently from 24d203f to b9b883f Compare February 19, 2019 16:18
@theresa-m
Copy link
Contributor Author

I've updated my commits from the review comments.

@DanHeidinga
Copy link
Member

@theresa-m Can you rebase this so it'll pick up with jvm interface fix? Then I can PR test it

@DanHeidinga DanHeidinga self-assigned this Feb 21, 2019
@theresa-m
Copy link
Contributor Author

the MethodType.describeConstable implementation is dependent on ClassDesc which hasn't been merged yet.

@DanHeidinga
Copy link
Member

@theresa-m Can you rebase and resolve the conflict?

@theresa-m
Tests for jep334 MethodType
51639df 
Signed-off-by: Theresa Mammarella <Theresa.T.Mammarella@ibm.com>
@theresa-m
Methods for jep334 MethodType
8ce58a6 
- describeConstable
- descriptorString

Signed-off-by: Theresa Mammarella <Theresa.T.Mammarella@ibm.com>
@theresa-m
Copy link
Contributor Author

@DanHeidinga its ready for a pr build now

@DanHeidinga
Copy link
Member

Jenkins test sanity plinux jdk12

@DanHeidinga
Copy link
Member

Only the known com.ibm.j9.jsr292.api.MethodHandleAPI_defineClass.test_defineClass_ClassBytes_CorruptedArray failure

@DanHeidinga DanHeidinga merged commit 7d70c48 into eclipse-openj9:master Feb 23, 2019
JEP 334 automation moved this from In progress to Done Feb 23, 2019
@theresa-m theresa-m deleted the jep334_methodtype branch February 25, 2019 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanHeidinga DanHeidinga DanHeidinga approved these changes

Assignees

@DanHeidinga DanHeidinga

Labels
comp:vm jdk12
Projects
No open projects
JEP 334
  
Done
Milestone
Release 0.13.0 (Java 12)
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@theresa-m @DanHeidinga @pshipton