-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup for Java12andUp tests (jep334) #4104
Conversation
54625a4
to
b0605d2
Compare
update copyright, merge conflict |
@llxia Can you or a delegate review this? |
32e9477
to
af14ebb
Compare
updated to resolve conflicting files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If its expected the Jep334Tests target work for jdk13, and on, then a minor change to subset to use 12+, otherwise LGTM
<group>functional</group> | ||
</groups> | ||
<subsets> | ||
<subset>12</subset> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am guessing these tests would be for 12+ subsets/versions.
As discussed in separate review, this can stay implementation-agnostic, until someone adds a variant/mode that contains a command line option that hotspot doesn't recognize. With NoOptions, its good as is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes it should be 12+. I will fix that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated with that change
- including playlist.xml entry for jep334 tests Signed-off-by: Theresa Mammarella <Theresa.T.Mammarella@ibm.com>
af14ebb
to
4d81e67
Compare
Launched Grinder: https://ci.eclipse.org/openj9/view/Test/job/Test-Grinder/272 @theresa-m - have you tried running this test target locally ? |
ooh just tried the test frame work does not like that its empty. I can lump this commit in with one of my prs that actually adds a test so there's no error. I made this separate because I wasn't sure which one would get merged first. sorry I didn't think that would be an issue |
Adding this commit to #4105 instead to avoid the compilation problem. |
no worries, we could have additionally added a dummy class in this PR, but looks like you have a good approach to shift it anyway :) Thanks for strengthening the jdk12 testing story, very much appreciated!! |
see #4195 for dependencies
Signed-off-by: Theresa Mammarella Theresa.T.Mammarella@ibm.com