-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IllegalStateException in org.eclipse.jface.text.TextViewer trying to save large CSS file in Graphical Conflict Resolution Editor #1043
Comments
@mickaelistria : the error seem to be coming from generic editor, could you please check:
|
@meldorq do you have Hyperlinking enabled? |
Yes. |
@meldorq Are you able to reproduce a similar issue by comparing this CSS file with another similar one in the workspace (no subclipse involved)? I guess not, but better be sure. |
No, I couldn't.
No. The "Git Merge Tool" didn't have any problem either in a similar merge situation with the same file. This is only a wild guess, but I believe the SVN graphical conflict resolution editor is somewhat dangling, i.e. it isn't directly connected to a file on the file system. So saving it requires more than just flushing a buffer to disk. The other compare editors show me the content of a file on disk vs. some other content, so here saving might more straightforward. Another difference is that the SVN graphical conflict resolution editor is initially dirty, i.e. displays the asterisk next to the file name in the editor tab. Maybe this is a useful hint? |
Also see the analysis at eclipse-wildwebdeveloper/wildwebdeveloper#1092 (comment) . |
Plus there was this PR: #1172 . |
@mickaelistria : is this issue solved now, or why it is still opened? |
I get a reproducible IllegalStateException in TextViewer when I try to save a large CSS file in the SVN graphical conflict resolution editor. The file has over 6000 lines.
The editor behaves normally, but when I try to save using ctrl-s, a popup opens, saying "Save Failed java.lang.IllegalStateException", and the editor remains unsaved.
I had originally reported the issue at subclipse subclipse/subclipse#274 but was told it's an eclipse issue. I hope I came to the right place.
Here is the stack trace: stacktrace.log
Installation details:
Version: 2023-06 (4.28.0)
Build id: 20230608-1333
The text was updated successfully, but these errors were encountered: