Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for rounded corners on rectangles and lists #510

Closed
1 task done
pcdavid opened this issue May 26, 2021 · 0 comments · Fixed by #516
Closed
1 task done

Add support for rounded corners on rectangles and lists #510

pcdavid opened this issue May 26, 2021 · 0 comments · Fixed by #516

Comments

@pcdavid
Copy link
Member

pcdavid commented May 26, 2021

  • I have checked that this feature has not yet been suggested by someone else.

Expected behavior

Sirius Desktop supports RoundedCornerStyleDescription with separate arcWidth and arcHeight attributes for various of its styles.

We will support a single borderRadius property at first. In the compatibility layer, if both arcWidth and arcHeight are set we will take the highest value.

Cuttings backs

Ideally we would support the whole CSS border-radius features, to allow for different radius on each of the 4 corners. This is not directly supported by SVG's <rect/> element but it could certainly be implemented by combining/overlaying mutiple rect with different radius settings.

Potential side effects

Edges which are connected to a rectangle or list container use the container's rectangular bounding box to compute their anchors, so with rounded corners the anchors can possibly looking disconnected. But this problem is already present with images for example.

pcdavid added a commit that referenced this issue May 27, 2021
Bug: #510
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@pcdavid pcdavid linked a pull request May 27, 2021 that will close this issue
pcdavid added a commit that referenced this issue May 28, 2021
Bug: #510
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau pushed a commit that referenced this issue May 28, 2021
Bug: #510
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant