Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the workbench independent from the concept of project #562

Closed
12 tasks
sbegaudeau opened this issue Jun 17, 2021 · 0 comments · Fixed by #580
Closed
12 tasks

Make the workbench independent from the concept of project #562

sbegaudeau opened this issue Jun 17, 2021 · 0 comments · Fixed by #580

Comments

@sbegaudeau
Copy link
Member

Problem

Our APIs and some of our lifecycle operations are still tightly couple with the expectation of a project.

Solution

Rename all occurrences of projectId to editingContextId and make sure we properly leverage the editing context indirection. For example in the GraphQL schema, the field Project#representation and Project#representations should probably move to the type EditingContext.

Rabbit holes

No-gos

Test

  • Automated developer tests merged and pass (with reasonable code coverage)
  • Automated End-to-End tests merged and pass (Cypress)
  • Feature/bug fix manually tested/validated by at least one person not involved in the implementation
  • Collaborative tests passed by hand
  • Exploratory test passed by MEB
  • Business acceptance test passed by MEB

Doc

  • Internal Doc updated
  • External Doc updated
  • Validation Doc updated

UX/UI

  • Zeroheight updated
  • Storybook updated

Next

  • Any left-over tasks added to the issues on Github
@sbegaudeau sbegaudeau added this to the 0.4.0 milestone Jun 19, 2021
@sbegaudeau sbegaudeau self-assigned this Jun 21, 2021
sbegaudeau added a commit that referenced this issue Jun 23, 2021
Bug: #562
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
sbegaudeau added a commit that referenced this issue Jun 23, 2021
The various subscriptions will now use editingContextId instead

Bug: #562
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
sbegaudeau added a commit that referenced this issue Jun 23, 2021
Bug: #562
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
sbegaudeau added a commit that referenced this issue Jun 23, 2021
The various subscriptions will now use editingContextId instead

Bug: #562
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
sbegaudeau added a commit that referenced this issue Jun 23, 2021
The fields Project#representation and Project#representations are now available
on the type EditingContext instead. It allows us to have features such as the
retrieval of the tools of a diagram or even the onboarding area independant from
the concept of Project.

Most of the references to the concept of project now remain in the mutations.

Bug: #562
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
sbegaudeau added a commit that referenced this issue Jun 23, 2021
Bug: #562
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
sbegaudeau added a commit that referenced this issue Jun 23, 2021
…ject

Bug: #562
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
@sbegaudeau sbegaudeau linked a pull request Jun 23, 2021 that will close this issue
sbegaudeau added a commit that referenced this issue Jun 23, 2021
Bug: #562
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
sbegaudeau added a commit that referenced this issue Jun 23, 2021
Bug: #562
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
sbegaudeau added a commit that referenced this issue Jun 23, 2021
Bug: #562
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
sbegaudeau added a commit that referenced this issue Jun 23, 2021
The various subscriptions will now use editingContextId instead

Bug: #562
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
sbegaudeau added a commit that referenced this issue Jun 23, 2021
The fields Project#representation and Project#representations are now available
on the type EditingContext instead. It allows us to have features such as the
retrieval of the tools of a diagram or even the onboarding area independant from
the concept of Project.

Most of the references to the concept of project now remain in the mutations.

Bug: #562
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
sbegaudeau added a commit that referenced this issue Jun 23, 2021
Bug: #562
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
sbegaudeau added a commit that referenced this issue Jun 23, 2021
…ject

Bug: #562
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
sbegaudeau added a commit that referenced this issue Jun 23, 2021
Bug: #562
Signed-off-by: Stéphane Bégaudeau <stephane.begaudeau@obeo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant