Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to contribute additional views to the left/right sites #693

Closed
12 tasks
sbegaudeau opened this issue Aug 16, 2021 · 0 comments · Fixed by #1085
Closed
12 tasks

Add the ability to contribute additional views to the left/right sites #693

sbegaudeau opened this issue Aug 16, 2021 · 0 comments · Fixed by #1085

Comments

@sbegaudeau
Copy link
Member

Problem

Some projects want to add new views to the left and right sites of the workbench.

Solution

We will add the ability to contribute new views to those sites. The views will be statically contributed at build time only. We will not try to perform any magical layout on those sites anymore (LeftSite only for now) since the combinatorial explosion will be massive.

Contributors will should only be able to provide the view with its name and content. A common TypeScript interface will be required in order to provide the same capabilities to all those views.

This issue should start with the contribution of an ADR and no development should start before the approval of said ADR.

Cutting backs

Rabbit holes

No-gos

Test

  • Automated developer tests merged and pass (with reasonable code coverage)
  • Automated End-to-End tests merged and pass (Cypress)
  • Feature/bug fix manually tested/validated by at least one person not involved in the implementation
  • Collaborative tests passed by hand
  • Exploratory test passed by MEB
  • Business acceptance test passed by MEB

Doc

  • Internal Doc updated
  • External Doc updated
  • Validation Doc updated

UX/UI

  • Zeroheight updated
  • Storybook updated

Next

  • Any left-over tasks in the Github issues
@sbegaudeau sbegaudeau added this to the 0.5.0 milestone Aug 16, 2021
@sbegaudeau sbegaudeau removed this from the 0.5.0 milestone Oct 7, 2021
pcdavid added a commit that referenced this issue Mar 3, 2022
Bug: #693
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Mar 3, 2022
Bug: #693
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Mar 3, 2022
Bug: #693
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@sbegaudeau sbegaudeau added this to the 2022.03.0 milestone Mar 4, 2022
@sbegaudeau sbegaudeau linked a pull request Mar 4, 2022 that will close this issue
17 tasks
pcdavid added a commit that referenced this issue Mar 7, 2022
Bug: #693
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Mar 7, 2022
Bug: #693
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Mar 7, 2022
Bug: #693
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Mar 7, 2022
Bug: #693
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Mar 7, 2022
Bug: #693
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Mar 7, 2022
Bug: #693
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Mar 7, 2022
- All the views will not use the same type of props
- The workbench will now have no views by default

Bug: #693
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Mar 7, 2022
- All the views will not use the same type of props
- The workbench will now have no views by default

Bug: #693
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid added a commit that referenced this issue Mar 8, 2022
Bug: #693
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
sbegaudeau pushed a commit that referenced this issue Mar 8, 2022
Bug: #693
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants