Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree Editor template fails on Theia next #124

Closed
JonasHelming opened this issue Nov 29, 2021 · 8 comments
Closed

Tree Editor template fails on Theia next #124

JonasHelming opened this issue Nov 29, 2021 · 8 comments

Comments

@JonasHelming
Copy link
Contributor

There are build errors when generating the tree-editor template on Theia next

@JonasHelming
Copy link
Contributor Author

@lucas-koehler : Is it possible to fix this?

@lucas-koehler
Copy link
Contributor

I will investigate later this week

@lucas-koehler
Copy link
Contributor

lucas-koehler commented Dec 1, 2021

@JonasHelming I investigated this and as far as I can tell the root cause of this is incorrect versioning of Theia's published next version.
Looking at https://www.npmjs.com/package/@theia/core/, the most recent next version is 1.18.0-next.177. However the latest version is 1.20.0.
With this, the next version is not newer than the latest version from the point of view of semantic versioning. This leads to the problem that the tree editor's dependency ^1.18.0 is resolved to 1.20.0 while next is resolved to 1.18.0-next.177.
I would expect that the next versions released after 1.20.0 are of format 1.21.0-next.1. This was always the case until 1.18.0. For some reason, the version number of the next version did not increase after the 1.18.0 release.

With different versions being resolved, the types are not compatible and, thus, the extension cannot be built.

@JonasHelming
Copy link
Contributor Author

@vince-fugnitto : Can you comment on this?

@vince-fugnitto
Copy link
Member

After a little bit of effort next releases should now be fixed, you can now confirm if that was the cause of the issues related to the tree-editor.

@lucas-koehler
Copy link
Contributor

lucas-koehler commented Dec 3, 2021

Thank you very much for the quick fix, @vince-fugnitto . Unfortunately, this did not fix it because versions like ^1.18.0 are not resolved to next even if they are compatible from a semantic versioning point of view. But I guess it was good to fix that anyway :)

Another idea I tried was to set resolutions in the root package.json. However, resolutions cannot be resolved to dist-tags (like next). See this issue on the yarn repository yarnpkg/yarn#6666 . If resolving to the most recent next version by using it's version directly, everything builds fine. Consequently, it definitely is a resolution issue and not related to changes in Theia itself.

I will investigate a solution in the tree editor package itself (e.g. peer depenencies for Theia).

@lucas-koehler
Copy link
Contributor

lucas-koehler commented Dec 10, 2021

@JonasHelming With the latest version of the tree editor, the generation should now work with Theia next. As we currently always use the next version for the tree editor, it should automatically work with new generation attempts.

@JonasHelming
Copy link
Contributor Author

works for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants