Theia Electron application menu fails on macOS

[jeanlucburot]

Theia Electron context menu fails on macOS. There should for instance be a View menu with entries such as Call hierarchy, Extensions, Files, Git, Git History, Outline, Output, ... But non of them are visible when run on macOS. Please see macOS screenshot.

Ran following command on macOS High Sierra 10.13.4 with node v8.11.1, npm 6.0.0, yarn 1.6.0:

git clone https://github.com/theia-ide/theia.git
cd theia
yarn
cd examples/electron
yarn run start

When trying to do the same on Ubuntu 16.04.4 LTS with node v8.11.1, npm 6.0.0, yarn 1.6.0 the script above fails when running yarn. So, yarn has to be run twice. But the end result works. The menu shows as expected. Please see Ubuntu screenshot.

git clone https://github.com/theia-ide/theia.git
cd theia
yarn
yarn
cd examples/electron
yarn run start

[AlexTugarev]

I verified this; it's broken since updating to v1.8.x of electron. maybe there are some api changes, and we need to catch up.

BTW in the meantime electron v2 was released.

[jeanlucburot]

Ok, thanks for confirming. Are there any plans yet to move the desktop version of Theia to Electron v2 anytime soon?

[kittaakos]

Quick question as I am doing the review of the corresponding PR; it is not the context menu but the application menu, right?

[jeanlucburot]

My understanding is:

• context menu: the right-click within the window somewhere, not outside of it.
• application menu: outside of the window, usually the top of the window frame. In the case of macOS the menu at the top of the screen. Same applies to Ubuntu with the Unity Desktop. Under Windows 10 this is a bit different; there it is the menu to the top of the window frame.

So this is about the application menu. Please see the above screenshot for that.

[kittaakos]

Closed via #2469.