Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[outline] Symbols added twice under parents when parent name is ambiguous #2303

Open
MarkZ3 opened this issue Jul 6, 2018 · 1 comment
Open
Labels
outline issues related to the outline

Comments

@MarkZ3
Copy link
Contributor

MarkZ3 commented Jul 6, 2018

Using Theia master as of today.

java-outline

This happens because here the algorithm that figures out which children are under the parent checks only if the parent name matches the candidate child's containerName (both unqualified). So because two parents can have the same unqualified name, a given symbol can be added to two different parents.
microsoft/language-server-protocol#327 would solve this.

@AlexTugarev
Copy link
Contributor

I think there were some changes made recently. Nodes are still added to wrong parent if the name is ambiguous, but no longer twice.

@vince-fugnitto vince-fugnitto added the outline issues related to the outline label Jul 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
outline issues related to the outline
Projects
None yet
Development

No branches or pull requests

3 participants