Replies: 2 comments 1 reply
-
What I'm afraid of with |
Beta Was this translation helpful? Give feedback.
1 reply
-
Do we still need to follow these steps to use maven dependencies in tycho projects? |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
With the recent changes in 2.7.x, and the move to maven 3.8.4 we now have an opportunity I'd like to discuss here that seems to me like a very interesting idea in regards of making Tycho more "maven-centric" but will possible be a complete change in the concept of dependency resolution.
Currently it roughly works like this:
For (2) we already use that information and has enhanced for the
dependency:list
support but the information will not be used any further in tycho itself.What I like to propose is, that we drop the "IDependencyMetadata" (or better redefine it) and work completely on the maven dependency model calculated at step (2), of course we still will need a mapping of mvn-dependency ->Installable unit but that's only relevant in certain cases.
As an example the compiler plugin can then just scan all dependencies of the pom and choose those that are bundles (or wrap any others if enabled) very similar to how the maven-compiler plugin would behave, and even handle the scopes appropriately (given we inject the correctly). This of course would mean that
pomDependecies=consider
is active by default, but would actually match what most maven-users would expect and it could simplify some of our tasks as one don't need to care about later stages if a dependency is correctly injected in the first place. There is one (minor) drawback, that maven would require to download all artifacts at the resolve stage but I think if that really hurts I think we should just improve maven to support a lazy model here.This is obviously something that won't happen today or tomorrow and probably will be painful in some areas as we need to rethink some concepts, but in the end I think will greatly improve how tycho works.
Beta Was this translation helpful? Give feedback.
All reactions