Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make referencedRepositoryMode=include the default for target-platform-configuration #3231

Closed
LorenzoBettini opened this issue Dec 11, 2023 · 4 comments · Fixed by #3252
Closed

Comments

@LorenzoBettini
Copy link
Contributor

As disccused here #3229 (comment)

@LorenzoBettini
Copy link
Contributor Author

@laeubi can these failures in my fork https://github.com/LorenzoBettini/tycho/actions/runs/7191995115/job/19590562389 be related to making referencedRepositoryMode=include the default? It looks like it tries to contact sites that don't exist anymore. Of course, I can update the corresponding IT projects POMs.

@laeubi
Copy link
Member

laeubi commented Dec 13, 2023

It looks like it tries to contact sites that don't exist anymore

Yes thats very likely.

I can update the corresponding IT projects POMs.

please do so, if you want to test locally usually a

mvn clean install -T1C -DskipTests

then

cd ~/git/laeubi/tycho/tycho-its
mvn clean install -Pits -Dtest=<your test>

works quite well.

@LorenzoBettini
Copy link
Contributor Author

OK, locally I reproduced the problem and fixed that like that LorenzoBettini@27d4db5

some of the reported failed ITs work on my machine without any modification, I'll investigate further

@LorenzoBettini
Copy link
Contributor Author

@laeubi everything seems to be green, I created the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants