Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with dependency types and artifactory Maven plugin #539

Closed
henryju opened this issue Jan 18, 2022 · 4 comments
Closed

Problem with dependency types and artifactory Maven plugin #539

henryju opened this issue Jan 18, 2022 · 4 comments
Milestone

Comments

@henryju
Copy link

henryju commented Jan 18, 2022

Hi,

After upgrading from Tycho 2.3.0 to 2.5.0, my build is failing. We are using the Artifactory plugin to record build informations, and it is supposed to collect all project dependencies.
The collection of dependencies contains things like:

       {
          "type" : "jar",
          "sha1" : "a68981b2c9df9c5f90c1f5022a5e15a3d8d70368",
          "md5" : "4f6632b90135f92ad6c1b1e2c25615f8",
          "id" : "p2.eclipse-plugin:org.eclipse.jface:3.23.0.v20210723-1324",
          "scopes" : [ "system" ]
        }, {
          "type" : "lucene-backward-codecs-5.5.5.jar",
          "sha1" : "d1dee5c7676a313758adb30d7b0bd4c69a4cd214",
          "md5" : "c584dcfc21ff1506d61477d5c4fb8f06",
          "id" : "p2.eclipse-plugin:org.eclipse.m2e.maven.indexer:1.18.0.20210618-2246",
          "scopes" : [ "system" ]
        }

The type attribute of the second dependency looks wrong from a Maven point of view. Are you aware of this problem?

FYI the error on Artifactory side is:

Caused by: com.mysql.cj.jdbc.exceptions.MysqlDataTruncation: Data truncation: Data too long for column 'dependency_type' at row 1

@mickaelistria
Copy link
Contributor

I believe the issue is on artifactory side; the type here should be jar, and lucene-backward-codecs-5.5.5 should probably be a classifier (it's an inner jar). The artifactory plugin seems to fail at parsing the depedency string correctly and tries to feed its DB with wrong values.
Anyway, not an issue on Tycho side.

@henryju
Copy link
Author

henryju commented Jan 19, 2022

OK, so you confirm Tycho is putting arbitrary long values as dependency classifiers?

I found the place where the artifactory plugin is building the type property, and indeed they are sometimes appending the classifier.

And for other people reference, I found this open issue on artifactory side:
https://www.jfrog.com/jira/browse/BI-477

Thanks

@mickaelistria
Copy link
Contributor

OK, so you confirm Tycho is putting arbitrary long values as dependency classifiers?

Yes, in case of nested jars.

@laeubi laeubi added this to the 2.7 milestone Feb 13, 2022
@henryju
Copy link
Author

henryju commented Feb 18, 2022

This issue can be closed, since it should have been fixed on artifactory plugin side: jfrog/artifactory-maven-plugin#29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants