-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for #444 and #433 #486
Conversation
jannehietamaki
commented
Jan 5, 2013
- Load java source files with getResource so java source verticles now work inside a module (fixes Java source verticles don't work inside module #444)
- Parse package definition from the java source and resolve java source root path based on that (fixes Java: Empty package name is not supported #433)
- Load java source files with getResource so java source verticles now work inside a module (fixes eclipse-vertx#444) - Parse package definition from the java source and resolve java source root path based on that (fixes eclipse-vertx#433)
Janne, When I create a module where the main is a Java source file in a package, it fails with the following: tim@tim-laptop ~/projects/vert-x/vert.x/vertx-examples/src/main/java/sourcemod $ ../../vertx-dev runmod test-mod-v1.0 I've added the example in master in vertx-examples/src/main/java/sourcemod |
Argh, sorry about that. Now it should work. |
Thanks Janne, this seems to work fine now :) I've also done a little cleanup in your code, your indentation is all over the place, and there are unused imports and fields too. |
I also added a more comple source module example which references other source files in the module. Thanks again! |
Yeah, ./mk eclipse did not generate anything and I was too lazy to import Vert.x stuff into IDE by hand so the indentations and imports were ugly. :( Also, it does not really use the classloader to load the sources, only to find them so packaging modules into jars wont probably work. But anyway, Java verticles are good for trying things out and not for serious development so I think it's good enough for now. |