Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support zc_reply_fifo_new_unbounded #528

Closed
YuanYuYuan opened this issue Jul 17, 2024 · 3 comments
Closed

Support zc_reply_fifo_new_unbounded #528

YuanYuYuan opened this issue Jul 17, 2024 · 3 comments

Comments

@YuanYuYuan
Copy link
Contributor

Describe the feature

A handler to an unbounded flume channel was supported in 0.11.0 but missing in 1.0.0.

@DenisBiryukov91
Copy link
Contributor

In 0.11.0 unbounded channel was created by passing a 0 channel size, now passing 0 creates a rendezvous channel. I believe Zenoh rust also does not support unbounded flume-channel as its predefined handler. It was discussed with @Mallets and agreed that it does not worth implementing unbounded channel in zenoh-c.

@YuanYuYuan
Copy link
Contributor Author

I see. Then let's close this issue 😁.

@YuanYuYuan YuanYuYuan closed this as not planned Won't fix, can't repro, duplicate, stale Jul 17, 2024
@wyfo
Copy link
Contributor

wyfo commented Jul 17, 2024

Unbounded is rarely a good idea. A lot of channels uses the same implementation for both bounded and unbounded, so there is no difference in memory use. flume is just a mutex around a VecDeque (I'm quite disappointed to discover that), so keeping it bounded to avoid overflowing the memory is always better, and passing usize::MAX has pretty much the same effect than as an unbounded one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants