Replace GradleClasspathContainer on project only if content changed #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just signed the ECA. How to re-run the ip-validation? |
|
Thank you for the fix and for thinking of a test case as well! This looks good to me. You need to sign off on your commit (commit -s) for the IP validation to accept it. |
oehme
approved these changes
Feb 11, 2017
…r content changed. Signed-off-by: Pascal Woelfle <pascal_woelfle@web.de>
|
@oehme IP validation is now successful. |
|
Thank you Pascal! |
|
You're welcome Stefan |
donat
added
an:enhancement
was:implemented
and removed
was:implemented
an:enhancement
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the problem that on each synchronization the GradleClasspathContainer is replaced on the project, although there are no changes. This issue caused on big projects unnecessary incremental builds, because the project description is marked as changed after the classpath container is replaced. See also Gradle discussion [1].
Eclipse internal checks if the old classpath container differs from the new classpath container [2]. Therefore the fix only implements the equals() and hashcode() of the GradleClasspathContainer to fix the problem.
[1] https://discuss.gradle.org/t/classpath-container-update-on-synchronization/21499
[2] org.eclipse.jdt.internal.core.SetContainerOperation.executeOperation()