feat(recommendations): Provide a plug-in for recommendations #916

benoitf · 2020-11-09T15:34:02Z

What does this PR do?

Provide a plug-in for recommendations

Open a workspace without plug-ins: provide featured plug-ins and ask to reload workspace
Open a workspace containing a devfile with plug-ins: suggest it (but not prompting restart)
When opening file: Inform that some plug-ins may exist (only if extensions.openFileRecommendations is set to true in devfile)

Screenshot/screencast of this PR

What issues does this PR fix or reference?

How to test this PR?

Starts a new workspace with this plug-in and a devfile without plug-ins but with java or go project.
--> should prompt to restart workspace and then have intellisense

Try to open some files like go or python: should suggest that existing plug-ins may be there (extensions.openFileRecommendations is set to true in devfile attributes)

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=next

benoitf · 2021-01-05T08:22:52Z

[crw-ci-test]

che-bot · 2021-01-05T08:38:26Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	docker.io/maxura/che-theia:916
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:916

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

che-bot · 2021-01-05T09:10:51Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:916
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:916

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

che-bot · 2021-01-06T15:16:45Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:916
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:916

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

che-bot · 2021-01-06T15:45:56Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:916
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:916

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

che-bot · 2021-01-07T15:25:07Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:916
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:916

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

benoitf · 2021-01-10T19:44:08Z

[crw-ci-test --rebuild]

che-bot · 2021-01-10T20:24:15Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	docker.io/maxura/che-theia:916
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:916

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

che-bot · 2021-01-20T16:15:55Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	docker.io/maxura/che-theia:916
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:916

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

che-bot · 2021-01-20T16:55:14Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	docker.io/maxura/che-theia:916
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:916

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

che-bot · 2021-03-01T16:29:07Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	quay.io/crw_pr/che-theia:916
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:916

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

che-bot · 2021-03-01T20:26:18Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	quay.io/crw_pr/che-theia:916
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:916

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

che-bot · 2021-03-01T21:40:53Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	quay.io/crw_pr/che-theia:916
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:916

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

benoitf · 2021-03-01T22:06:46Z

[crw-ci-test --rebuild]

benoitf · 2021-03-01T22:07:36Z

Hello, testing as a user with this devfile:
So it doesn't do anything at startup of the workspace. Then when I open a Java file, installing the recommended plugins works.

there was a dependency issue on workspace-plugin (now it's marked as explicit dependency in package.json) so some events were not triggered. and there was a glitch in featured.json file.

should be fixed now

For the installation of recommended plugins when opening the java file (Could be done in another iteration):
would be nice to tell the user to restart the workspace

Should be implemented now

would be nice to show a list (not json content) of plugins to install

I think it's a comma separated list of pluginId ?
I agree it's not the best and UX team has been involved few weeks ago to provide enhancements (for all user interactions) and will provide feedback

would be nice to be able to choose the recommended plugins to install (at the moment, install java8 and java11 and quarkus11, etc ....) or install only one!

I tried but I faced eclipse-theia/theia#5673 (Theia is not handling the canPickMany option in QuickPick)

che-bot · 2021-03-01T22:43:15Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	quay.io/crw_pr/che-theia:916
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:916

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

che-bot · 2021-03-01T23:47:14Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	quay.io/crw_pr/che-theia:916
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:916

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

che-bot · 2021-03-02T09:59:46Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	quay.io/crw_pr/che-theia:916
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:916

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

che-bot · 2021-03-02T11:01:01Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	quay.io/crw_pr/che-theia:916
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:916

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Devfile without plug-ins: provide featured plug-ins and ask to reload workspace With plug-ins: suggest it When opening file: Inform that some plug-ins may exist Change-Id: I5d35f5329f44504e4e6fcad3ba198aa932d50252 Signed-off-by: Florent Benoit <fbenoit@redhat.com>

che-bot · 2021-03-02T12:54:19Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	quay.io/crw_pr/che-theia:916
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:916

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

sunix · 2021-03-02T12:57:25Z

Last changes:

Fix problem no startup recommendation when starting a devfile with just a java project and the che-theia editor.
We agree to Florent to disable the recommendation when a file is open. It is installing all the plugins related to Java (java11, java8, quarkus8, quarkus11, camel, etc.) but the user would just want to select one or two, but not all. And we cannot check the plugins to install because of this issue: [vscode] window.showQuickPick canPickMany is not supported eclipse-theia/theia#5673. There is a preference option to enabling it.
small code refactor

sunix

LGTM

sunix · 2021-03-02T13:07:08Z

Restart is not working but covered with eclipse-che/che#19174

ericwill · 2021-03-02T13:41:40Z

@tsmaeder any comments left from your side? Otherwise it's good to merge IMO

tsmaeder · 2021-03-02T15:03:21Z

Nope, all good.

benoitf force-pushed the CHE-18274 branch from ebe0f93 to 4f4c87f Compare November 9, 2020 15:47

This comment has been minimized.

Sign in to view

benoitf force-pushed the CHE-18274 branch from 4f4c87f to b8d9c7e Compare January 4, 2021 16:05

This comment has been minimized.

Sign in to view

benoitf force-pushed the CHE-18274 branch from b8d9c7e to 6c235b9 Compare January 5, 2021 08:54

benoitf force-pushed the CHE-18274 branch from 6c235b9 to 0d01641 Compare January 6, 2021 15:03

benoitf force-pushed the CHE-18274 branch from 0d01641 to afa385a Compare January 6, 2021 15:30

benoitf force-pushed the CHE-18274 branch 3 times, most recently from ce05290 to ed8c086 Compare January 7, 2021 15:04

benoitf force-pushed the CHE-18274 branch from ed8c086 to 3142910 Compare January 20, 2021 15:39

benoitf force-pushed the CHE-18274 branch from 3142910 to 0df4bb6 Compare January 20, 2021 16:21

benoitf marked this pull request as ready for review January 21, 2021 09:20

benoitf requested review from azatsarynnyy, ericwill, svor, tsmaeder, vinokurig and vitaliy-guliy as code owners January 21, 2021 09:20

ericwill requested a review from sunix January 22, 2021 13:35

benoitf force-pushed the CHE-18274 branch 2 times, most recently from e09bbf1 to fb8b787 Compare March 1, 2021 19:43

benoitf force-pushed the CHE-18274 branch 2 times, most recently from b381b42 to f2bcd72 Compare March 1, 2021 21:05

benoitf force-pushed the CHE-18274 branch from f2bcd72 to 38e9422 Compare March 1, 2021 21:46

benoitf force-pushed the CHE-18274 branch from 38e9422 to d14b7a4 Compare March 1, 2021 22:44

benoitf force-pushed the CHE-18274 branch from d14b7a4 to 67b59a6 Compare March 2, 2021 08:43

benoitf force-pushed the CHE-18274 branch 2 times, most recently from 75eaa4b to b1450b2 Compare March 2, 2021 10:11

benoitf force-pushed the CHE-18274 branch from 5159236 to 472aaac Compare March 2, 2021 12:06

sunix self-requested a review March 2, 2021 13:04

sunix approved these changes Mar 2, 2021

View reviewed changes

benoitf merged commit 84fa2c9 into eclipse-che:master Mar 2, 2021

benoitf deleted the CHE-18274 branch March 2, 2021 15:05

che-bot added this to the 7.27 milestone Mar 2, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(recommendations): Provide a plug-in for recommendations #916

feat(recommendations): Provide a plug-in for recommendations #916

benoitf commented Nov 9, 2020 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

benoitf commented Jan 5, 2021

che-bot commented Jan 5, 2021

che-bot commented Jan 5, 2021

che-bot commented Jan 6, 2021

che-bot commented Jan 6, 2021

che-bot commented Jan 7, 2021

benoitf commented Jan 10, 2021

che-bot commented Jan 10, 2021

che-bot commented Jan 20, 2021

che-bot commented Jan 20, 2021

che-bot commented Mar 1, 2021

che-bot commented Mar 1, 2021

che-bot commented Mar 1, 2021

benoitf commented Mar 1, 2021

benoitf commented Mar 1, 2021

che-bot commented Mar 1, 2021

che-bot commented Mar 1, 2021

che-bot commented Mar 2, 2021

che-bot commented Mar 2, 2021

che-bot commented Mar 2, 2021

sunix commented Mar 2, 2021 •

edited

Loading

sunix left a comment

sunix commented Mar 2, 2021

ericwill commented Mar 2, 2021

tsmaeder commented Mar 2, 2021

feat(recommendations): Provide a plug-in for recommendations #916

feat(recommendations): Provide a plug-in for recommendations #916

Conversation

benoitf commented Nov 9, 2020 • edited Loading

What does this PR do?

Screenshot/screencast of this PR

What issues does this PR fix or reference?

How to test this PR?

PR Checklist

Reviewers

Happy Path Channel

This comment has been minimized.

This comment has been minimized.

benoitf commented Jan 5, 2021

che-bot commented Jan 5, 2021

che-bot commented Jan 5, 2021

che-bot commented Jan 6, 2021

che-bot commented Jan 6, 2021

che-bot commented Jan 7, 2021

benoitf commented Jan 10, 2021

che-bot commented Jan 10, 2021

che-bot commented Jan 20, 2021

che-bot commented Jan 20, 2021

che-bot commented Mar 1, 2021

che-bot commented Mar 1, 2021

che-bot commented Mar 1, 2021

benoitf commented Mar 1, 2021

benoitf commented Mar 1, 2021

che-bot commented Mar 1, 2021

che-bot commented Mar 1, 2021

che-bot commented Mar 2, 2021

che-bot commented Mar 2, 2021

che-bot commented Mar 2, 2021

sunix commented Mar 2, 2021 • edited Loading

sunix left a comment

Choose a reason for hiding this comment

sunix commented Mar 2, 2021

ericwill commented Mar 2, 2021

tsmaeder commented Mar 2, 2021

benoitf commented Nov 9, 2020 •

edited

Loading

sunix commented Mar 2, 2021 •

edited

Loading