Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for PATs in GitHub Enterprise server #22582

Closed
etsauer opened this issue Oct 4, 2023 · 0 comments · Fixed by eclipse-che/che-server#603
Closed

Add support for PATs in GitHub Enterprise server #22582

etsauer opened this issue Oct 4, 2023 · 0 comments · Fixed by eclipse-che/che-server#603
Assignees
@vinokurig
Labels
area/factory/server Server side of factory implementation kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system. sprint/current team/A This team is responsible for the Che Operator and all its operands as well as chectl and Hosted Che

Comments

@etsauer
Copy link

etsauer commented Oct 4, 2023

Is your enhancement related to a problem? Please describe

When a developer that has GitHub Enterprise Server creates a PAT and tries to load it in from the 'User Preferences > Personal Access Tokens' menu in the Dashboard, they get an error that says that the token is not valid, even though it is a valid token. It appears we just haven't added support for GitHub Enterprise Server yet (i'm guessing the validation logic for an alternate URL must be different).

Describe the solution you'd like

I would like to see support added for individual users to add their PATs from Github Enterprise Server (self-hosted github). Today it looks like we only support GitHub.com and GitHub Enterprise Cloud, but I would like the same experience for Enterprise Server.

Describe alternatives you've considered

I believe the oauth integration is supported for GitHub Server, so that's an alternate path, but for a smooth Day 1 or POC experience, it would still be great to have support for PATs so that we don't need to engage with cluster admins just to create a workspace from a git repo.

Additional context

No response
@etsauer etsauer added the kind/enhancement A feature request - must adhere to the feature request template. label Oct 4, 2023
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Oct 4, 2023
@dmytro-ndp dmytro-ndp added severity/P1 Has a major impact to usage or development of the system. team/A This team is responsible for the Che Operator and all its operands as well as chectl and Hosted Che area/factory/server Server side of factory implementation and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Oct 4, 2023
@vinokurig vinokurig mentioned this issue Nov 7, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vinokurig vinokurig

Labels
area/factory/server Server side of factory implementation kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system. sprint/current team/A This team is responsible for the Che Operator and all its operands as well as chectl and Hosted Che
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for PATs in GitHub Enterprise server eclipse-che/che-server
5 participants
@dmytro-ndp @ibuziuk @etsauer @vinokurig @che-bot